convictional / trigger-workflow-and-wait

Trigger a workflow in another (or same) repository and wait for the job to finish.
MIT License
314 stars 151 forks source link

wait_interval cannot be set #19

Closed patrick1990 closed 2 years ago

patrick1990 commented 3 years ago

It's seems that I cannot set the wait_interval to a custom value. If I set it to 20 in my github workflow, it still uses the default of 10 seconds.

I'm pretty new to github actions, but I would guess the problem is, that entrypoint.sh#L16 wants to read the environment variable "INPUT_WAITING_INTERVAL" instead of the declared action input wait_interval in action.yml#L35.

MarkoSagadin commented 3 years ago

Yes, @patrick1990 you are correct, I just check the documentation; which says that a lowercase input variable is converted to uppercase and prepended with "INPUT_". I hope for a quick fix :)

smfeest commented 2 years ago

It looks like this is the issue addressed by the first commit in #34. Perhaps there's a case for cherry picking that fix separately if the rest of the PR isn't ready for release?