search

convictional / trigger-workflow-and-wait

Trigger a workflow in another (or same) repository and wait for the job to finish.
MIT License
311 stars 151 forks source link

Matrix jobs all log fail if only one fails #78

Open brianjmurrell opened 1 year ago

brianjmurrell commented 1 year ago

If I create a workflow with a job that uses convictional/trigger-workflow-and-wait as a step in a 2 axis matrix, if (even only) one of the matrix jobs fails, all of them show as failed in the workflow.

Additionally, both jobs in the workflow show the work of convictional/trigger-workflow-and-wait for both of the axes of the matrix.

See https://github.com/daos-stack/argobots/actions/runs/3541802004/jobs/5946573980 for an example of this. Only Test RPMs on EL 8 (release/2.2) actually failed. _Test RPMs on EL 8 (master) actually succeeded.

brianjmurrell commented 1 year ago

Any ideas here? I like this action, but it's failure here is going to be a blocker to being able to use it unfortunately.

brianjmurrell commented 1 year ago

I see the logs for the example run I mentioned in my original description have expired. Would it be helpful if I recreated them?

lironmatityahu commented 11 months ago

can you solve this issue? this is making my workflows complicated

orim-orca commented 7 months ago

@brianjmurrell it feels a bit more random than that. It should also sometimes succeed even if one fail, as the job will get the last running job of the one its triggering, and most of the times it will just be the last one triggered in the matrix.

The only solution I can think for this is some sleep mechanism for the matrix items, making you run them all in a window bigger than your wait window (which is usually 10 seconds)