Closed fisuda closed 4 years ago
Hi @fisuda!
Thank you very much for this PR, it is a great improvement.
Just comment a couple of details, dist
files are only updated on release, so it would be better if you can remove those changes from your PR. In any case, my idea is to make a full release just after merging your PR.
The other point is that I prefer to use 1.3.0 for next version of ngsijs, it would be great if you can update @since
annotations 😃.
Once again, thank you very much for this contribution!
Hi @aarranz,
Thank you for your comment. I have just updated the PR.
Thank you.
Hi @aarranz,
Thank you very much for taking your precious time for merging and releasing it. I'd like to transfer the ownership of the NGSI registration browser widget repository to your account on the GitHub. I'm looking forward to your reply.
Github help : Transferring a repository
Thank you.
Hi @aarranz,
I have implemented the NGSIv2 registration management operations (Issue #20) in the ngsijs library. As of now it seems that
PATCH /v2/registrations/{id}
is not implemented in Orion 2.3 yet.And I also made NGSI Registration browser widget. It is based on NGSI Subscription browser widget. I'd like to transfer the ownership to the wirecloud-fiware organisation on the GitHub.
It would be great if you could find the time to review this PR.
Thank you.