conwetlab / ngsijs

JavaScript library for the FIWARE Context Broker services (web browsers & Node.js)
11 stars 15 forks source link

Add the NGSIv2 registration management operations (close #20) #31

Closed fisuda closed 4 years ago

fisuda commented 4 years ago

Hi @aarranz,

I have implemented the NGSIv2 registration management operations (Issue #20) in the ngsijs library. As of now it seems that PATCH /v2/registrations/{id} is not implemented in Orion 2.3 yet.

And I also made NGSI Registration browser widget. It is based on NGSI Subscription browser widget. I'd like to transfer the ownership to the wirecloud-fiware organisation on the GitHub.

It would be great if you could find the time to review this PR.

Thank you.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.4%) to 91.1% when pulling 7245e3724d1ad22274896f746169cf3957b71e2a on fisuda:feature/v2registrations into 2d9bc6fc9cb52f978e8d99fbbd2575a5270790f1 on conwetlab:master.

aarranz commented 4 years ago

Hi @fisuda!

Thank you very much for this PR, it is a great improvement.

Just comment a couple of details, dist files are only updated on release, so it would be better if you can remove those changes from your PR. In any case, my idea is to make a full release just after merging your PR.

The other point is that I prefer to use 1.3.0 for next version of ngsijs, it would be great if you can update @since annotations 😃.

Once again, thank you very much for this contribution!

fisuda commented 4 years ago

Hi @aarranz,

Thank you for your comment. I have just updated the PR.

Thank you.

fisuda commented 4 years ago

Hi @aarranz,

Thank you very much for taking your precious time for merging and releasing it. I'd like to transfer the ownership of the NGSI registration browser widget repository to your account on the GitHub. I'm looking forward to your reply.

Github help : Transferring a repository

Thank you.