search

conwnet / github1s

One second to read GitHub code with VS Code.
https://github1s.com
MIT License
22.82k stars 865 forks source link

Jupyter Notebook Previewer not working #216

Open chuabern opened 3 years ago

chuabern commented 3 years ago

image ![Uploading image.png…]()

when I click on show preview when trying to open up an .ipynb file, the preview is not working.

xcv58 commented 3 years ago

Could you please share a reproducible link?

chuabern commented 3 years ago

@xcv58 i just tried it out and realized it's working fine with ipynb files in public repos, but when i open it from a private repo this error comes up

conwnet commented 3 years ago

i just tried it out and realized it's working fine with ipynb files in public repos, but when i open it from a private repo this error comes up

@chuabern

Yes. the jupyter extension use jupyter.org for a preview now, which cant access the private repos. And the special characters in the path/filename of the jupyter file also can be break the extension.

We will try to make a real jupyter viewer extension next.

chuabern commented 3 years ago

that sounds good! Looking forward.