search

conwnet / github1s

One second to read GitHub code with VS Code.
https://github1s.com
MIT License
22.82k stars 865 forks source link

Unable to get the latest files for GitHub projects #463

Closed fhefh2015 closed 1 year ago

fhefh2015 commented 1 year ago

The project: https://github.com/fhefh2015/Fast-GitHub

I opened the same project using Safari, without logging into Github.

CleanShot 2022-11-15 at 17 14 53@2x

Open with github1s.com https://github1s.com/fhefh2015/Fast-GitHub/tree/main/fast_github PC Screenshot

CleanShot 2022-11-15 at 17 10 09@2x

Mobile Screenshot

CleanShot 2022-11-15 at 17 17 35@2x

Open with github.dev https://github.dev/fhefh2015/Fast-GitHub/tree/main/fast_github

CleanShot 2022-11-15 at 17 10 45@2x
conwnet commented 1 year ago

Thanks you for your feedback.

We use sourcegrpah Api default, it seems sourcegraph forget to sync the latest code from this repo.

Unfortunately, we lost this bad case now. (now we will get the correct result when we visit this repo)

But I think there really may be a big latecy here, As I see, we should use GitHub API for logged users, and only use Sourcegraph Api for anonymous users default.

fhefh2015 commented 1 year ago

Thanks for the reply, the problem is solved.

Siddhant-K-code commented 1 year ago

But I think there really may be a big latecy here, As I see, we should use GitHub API for logged users, and only use Sourcegraph Api for anonymous users default

Yes, @conwnet that would also be our issue of Code Search in Private Repositories. It doesn't work right now, we are calling Sourcegraph APIs by default (in both cases). I think we can directly consume GitHub APIs for GH logged in Users.