conwnet / github1s

One second to read GitHub code with VS Code.
https://github1s.com
MIT License
22.82k stars 865 forks source link

fix: home logo with light theme #464

Closed wolfsilver closed 1 year ago

wolfsilver commented 1 year ago

The current logo does not perform well on some light themes.

PS: vscode needs rebuild.

image

welcome[bot] commented 1 year ago

Hello there!👋 Welcome to the project!💖 Thank you and congrats🎉 for opening your first pull request✨ 🙌.We will get back to you as soon as we can.😄

vercel[bot] commented 1 year ago

@wolfsilver is attempting to deploy a commit to the Github1s Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
github1s ✅ Ready (Inspect) Visit Preview Dec 30, 2022 at 5:44AM (UTC)
wolfsilver commented 1 year ago

SVGs are looking weirdly enlarged. can you pls reduce the size a little bit?

svg is a vector image, I'll keep it same size with github.svg.

wolfsilver commented 1 year ago

In Review, in dark mode. Logo is not visible.

image

Doesn't Review mode rebuild vscode?

conwnet commented 1 year ago

Doesn't Review mode rebuild vscode? review mode wouldn't rebuild vscode due to speed now. Thanks your for you contribution. let me rebuild it and make it work.

conwnet commented 1 year ago

Thank you for your work! I think we can use the css mask attribute instead of background to solve this problem. I prefer to keep a concise API, which is more convenient for users.

wolfsilver commented 1 year ago

Thank you for your work! I think we can use the css mask attribute instead of background to solve this problem. I prefer to keep a concise API, which is more convenient for users.

Sorry,I didn't get it. Different themes set different colors on the parent node. I don't know which css mask attribute can solve this problem.

conwnet commented 1 year ago

Sorry,I didn't get it. Different themes set different colors on the parent node. I don't know which css mask attribute can solve this problem.

I have opened a PR here: https://github.com/wolfsilver/github1s/pull/1/files

welcome[bot] commented 1 year ago

Congrats on merging your first pull request! 🎉🎉🎉 We here at github1s are proud of you!