search

conwnet / github1s

One second to read GitHub code with VS Code.
https://github1s.com
MIT License
22.79k stars 863 forks source link

Update devcontainers version to Node 20 #525

Closed weaversam8 closed 11 months ago

weaversam8 commented 11 months ago

Using the devcontainers approach mentioned in the README did not work on my Apple Silicon Mac. To fix it, I updated the devcontainer image to use a newer node version, and updated the version of emsdk. Both now support the arm64 architecture.

welcome[bot] commented 11 months ago

Hello there!👋 Welcome to the project!💖 Thank you and congrats🎉 for opening your first pull request✨ 🙌.We will get back to you as soon as we can.😄

vercel[bot] commented 11 months ago

@weaversam8 is attempting to deploy a commit to the Github1s Team on Vercel.

A member of the Team first needs to authorize it.

weaversam8 commented 11 months ago

I realized I needed to update one underlying devdependency for this package, eslint-plugin-jsdoc. I did that and tested the application in the latest commit, and it works as expected.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
github1s ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 7:59am
welcome[bot] commented 11 months ago

Congrats on merging your first pull request! 🎉🎉🎉 We here at github1s are proud of you!