conzos-angels / iQ-scripts

iQ scripts for support purposes
GNU General Public License v3.0
0 stars 0 forks source link

Read laser hours of all lasers #2

Open Francissss opened 10 years ago

Francissss commented 10 years ago
omsai commented 10 years ago

You made good progress on Friday. Regarding the difference in string handling you noticed between Python 2.7 and Python 3.4: the specific is documented and discussed [upstream](https://en.wikipedia.org/wiki/Upstream_%28software_development%29 upstream) here: http://sourceforge.net/p/pyserial/bugs/106/

Best practise is to check-in your code often (try to follow the UCSF recommendation of doing it at least at once a day even if the code is worse off than before). Since your work is pre-alpha, instead of adding code into the master branch you should create a new branch: https://help.github.com/articles/fork-a-repo#create-branches I believe you would have to create the branch from the command-line. GitHub for Windows used to install a separate start menu shortcut to take the trouble out of running git this way, but if I remember correctly, one can now do this from within the GitHub GUI instead (probably by right-clicking on the project). Name branch after the feature you are adding.

Once you have your code checked in I will be able to add comments inline, online.

omsai commented 10 years ago

You've made good progress on the program, and there are a fair number of changes I've suggested you make. Hopefully you have a chance to test it out soon in the field.

At some point you should also read Dive into Python 3