search

coobird / thumbnailator

Thumbnailator - a thumbnail generation library for Java
MIT License
5.08k stars 780 forks source link

Jigsaw modules support #196

Open Auties00 opened 2 years ago

Auties00 commented 2 years ago

Hello, I'd like to use this library in one of my projects, though I noticed that it doesn't provide a module info. I was going to add one myself and create a PR, but as soon as I pulled the repo I noticed that the minimum version supported is Java 5. I'd still like to implement this feature and get it merged, so, if it's something that can be useful for the library, should I bump the minimum version to Java 11 or resort to some magic using moditect's plugin?

coobird commented 2 years ago

Bumping the minimal supported Java version to 11 is out of the question, given that its adoption is nowhere near universal. It would likely break many projects that already depend on Thumbnailator.

Looking around, it looks like there are ways to target lower versions of Java with module-info.java included, so I could look at those options. In that case, only a bump up to Java 6 would be required.

But in any case, supporting modules is not a high-priority at this point. If you need them right now, your option would be to use rely on tooling that can provide the necessary module descriptors that you want.

torakiki commented 1 year ago

Can you please at least add an automatic module name to the manifest? http://branchandbound.net/blog/java/2017/12/automatic-module-name/

coobird commented 1 year ago

@torakiki, thanks, I will look into this :)

coobird commented 1 year ago

I'll add an Automatic-Module-Name in #202.

coobird commented 1 year ago

Just FYI, an Automatic-Module-Name has been added to the manifest in the 0.4.19 release.