search

coobird / thumbnailator

Thumbnailator - a thumbnail generation library for Java
MIT License
5.17k stars 789 forks source link

Scale up disabled feature #87

Closed radoslavdodek closed 1 year ago

radoslavdodek commented 8 years ago

Hi,

I've implemented one tiny feature called "Scale Up disabled", which lets you enable/disable scaling thumbnail up in case thumbnail size is set bigger than original image. Usually I don't want to scale up a thumbnail as this creates a distortion of the image. I only want to scale it down if necessary. Please take a look on it and if you find it useful, feel free to merge it into main repository. Also feel free to contact me with any questions or requests.

Radoslav.

radoslavdodek commented 8 years ago

I've just noticed that there is an Issue (#85) opened asking for similar feature as the one I've implemented.

nioe commented 8 years ago

Any updates on this? Would be very cool if this PR could be merged if there are no other concerns.

mwiehl commented 8 years ago

This PR contains a lot of white spaces changes. A PR should generally address only a single concern; any code re-formatting should be done separately.

thiago-negri commented 8 years ago

I'm in need of this feature, but the whitespace changes are unnecessary.

I'll try to extract only the real changes.

thiago-negri commented 8 years ago

I've created PR #94 for this and used a positive property "scaleUp" instead of a negative one "scaleUpDisabled".

radoslavdodek commented 8 years ago

Thanks thiago-negri, as I didn't have time to remove unnecessary white spaces, your PR will help the others to use this feature.

nqzero commented 6 years ago

for a work-around see https://github.com/coobird/thumbnailator/pull/94#issuecomment-366489245

coobird commented 1 year ago

Thank you for your interest! Pull requests are currently not being accepted.