search

cookbooks / chef-client

A Chef cookbook for chef-client
http://cookbooks.github.com/chef-client
6 stars 6 forks source link

Update attributes/default.rb #1

Closed ChrisLundquist closed 11 years ago

ChrisLundquist commented 12 years ago

Add scientific linux

ChrisLundquist commented 12 years ago

What do you think about moving towards a "value_for_platform_family" style http://rubydoc.info/gems/chef/Chef/Mixin/Language#value_for_platform_family-instance_method ? Seems like it might better catch all the different flavors of RHEL and Debian.

Then overriding on a platform by platform basis if it is divergent from the family.

hedgehog commented 12 years ago

I'm quite happy if you think that will work best. Given this is one of the core opscode cookbooks you might want to discuss the change on the email list. I know the Opscode contribution hurdles are higher, and take longer, than for this repo, but have you considered contributing there. If that doesn't appeal I'm still happy to accept the change, but someone will need to manage merging changes from upstream (Opscode) master. Ideally, going forward from here, we'd have a maintainer for this cookbook, who would merge the master branch changes into the qa branch. Hint ;)

I've been busy on another project so have not automated pulling upstream's master into this repo's master will try to get onto that shortly.

If you do decide to make that change I'd like you get get someone who uses this cookbook to comment +1 on your proposed changes.

hedgehog commented 12 years ago

@ChrisLundquist, just a headup... after the Opscode re-oganization of their repos, we are now tracking opscode's chef-client in cookbooks/oc-chef-client.

This repo will stay around. The idea of these prefix-free repos is that they give a degree of freedom to track different vendors overtime. Ideally they are maintained by people who manage the upstream changes. Example, vendor X drops cookbook Y, vendor A picks-up cookbook Y. The repo cookbooks/y would switch from merging changes in cookbooks/x-y to merging changes in cookbooks/a-y.

Current example is the ruby_enterprise cookbook, which was dropped by Opscode and then picked-up by @miketheman.

We are still in the suck-it-and-see phase, so it is not clear how the devops world will prefer to work.... Your thoughts?

ChrisLundquist commented 12 years ago

I'm just hoping to get this merged. I have never before had such a challenging time to get a string added.

https://github.com/opscode/cookbooks/pull/411

https://github.com/opscode-cookbooks/chef-client/pull/17

miketheman commented 12 years ago

Sorry to hear about your experience. Did you ever open an associated Jira ticket? I think that's one of the steps here: http://wiki.opscode.com/display/chef/How+to+Contribute

ChrisLundquist commented 12 years ago

No, not this time. Last time I did that it with no avail. http://tickets.opscode.com/browse/OHAI-284 https://github.com/opscode/ohai/pull/37

I saw,

We Welcome GitHub Pull Requests
A one-time CLA submittal - and relating pull requests to trouble ticket(s) - provides for managing submittals across the projects, for fulfilling Apache licensing, and resulting in your successful and appreciated contribution to the community.

And took it at face value.

Shall I make a Jira issue to match this pull request? I am really eager to help, but have been given many road blocks in trying to do so. What is the best way for me to proceed? I seem to be getting conflicting information.

miketheman commented 12 years ago

I guess it has to do with getting familiar with their process - something I have spoken to community leaders about previously.

It seems like the process is to sign the CLA, get added to the contributors (developers on jira), open a jira ticket, commit the code with good comments, in atopic branch in your own fork, then issue a pull request, and "Resolve" the ticket in Jira, with a link to the pull request.

The "Resolve" part is actually important, since the reviewers look for tickets that have been resolved, and focus attention there first.

Does this help at all?

hedgehog commented 12 years ago

@ChrisLundquist, there seems to be some confusion, and you are not alone in that. The devops world has yet to settle on workflows, we are part of that process along with several other tool authors and cookbook vendors. Apologies, but devops is definitely a world covered with wet-paint signs ;)

Hopefully this will clarify:

The repositories under this organization are not affiliated with Opscode. We track Opscode cookbook repositories in the same way we track any other cookbook vendor/maintainer. Contributing to the cookbooks repositories should be as straight forward as: 1) updating the qa branch to the master branch, 2) making your changes against the updated qa branch, and 3) ensuring your pull requests merges cleanly against the updated qa branch.

More details in the cookbooks/about repository.