cookieconsentio / gtm-cmp-main-template

CookieConsent.io Google Tag Manager main template
Apache License 2.0
0 stars 1 forks source link

Template review feedback #1

Open praveena-pappu opened 3 years ago

praveena-pappu commented 3 years ago

Thanks for submitting a template to the gallery, there were a few issues in your template that needed to be resolved ahead of approving the template for the gallery.

1) encodeUriComponent should be used on user provided values that are then used as parameters in your url. These methods take in a single text argument and return a URI Encoded string. You should use this method on user input values when generating the url const url = 'https://edge.cookieconsent.io/prod/js/' +data.id + '.js?hidden=' + data.hidden + '&backdrop=' + data.backdrop + '&backdrop_color=' + data.backdrop_color + '&position=' + data.position + '&functional=' + data.functional + '&marketing=' + data.marketing + '&analytics=' + data.analytics + '&google_consent_mode=' + data.google_consent_mode;

cookieconsentio commented 3 years ago

Dear Praveena,

Thank you for you're feedback. We have made some alterations after you're feedback:

https://github.com/cookieconsentio/gtm-cmp-main-template/commit/d3d0db0c9b3173b1e92edb718e52555bf7c74d5d#diff-dfeab1de57b435942d72fd2eef60b735ad864ee7b35692d09d05d0536ffce292

Can you review the modifications? Thank you.

Kind regards,

Jack Kwakman Senior Developer CookieConsent.io

cookieconsentio commented 3 years ago

Dear Praveena,

Thank you for accepting the template. We have another variable template in review for easy reading the CookieConsent.io consent state:

https://github.com/cookieconsentio/gtm-consent-state

Can you also review this variable template? It is so much easier for the end user to select this community template instead of the firing separate events in GTM. We already created docs for the integration but are waiting for the approval of the variable template to also add this section to our docs:

https://www.cookieconsent.io/developers/

Can you please review our variable template? If there are any issues please let me know. Thank you.

Kind regards,

Jack Kwakman Senior Developer CookieConsent.io

cookieconsentio commented 3 years ago

Dear Praveena,

We have another template in review for our Facebook Server 2 Server template.

https://github.com/cookieconsentio/gtm-facebook-s2s-template

Can you also review this template?

We already created docs for the integration but are waiting for the approval of the template to also add this section to our docs:

https://www.cookieconsent.io/developers/

Can you please review our template? If there are any issues please let me know. Thank you.

Kind regards,

Jack Kwakman Senior Developer CookieConsent.io

cookieconsentio commented 2 years ago

Dear Praveena,

We have another template in review for our TikTok Server 2 Server template.

https://github.com/cookieconsentio/gtm-tiktok-s2s-template

Can you also review this template?

We already created docs for the integration but are waiting for the approval of the template to also add this section to our docs:

https://www.cookieconsent.io/developers/

Can you please review our template? If there are any issues please let me know. Thank you.

Kind regards,

Jack Kwakman Senior Developer CookieConsent.io

cookieconsentio commented 1 year ago

Dear Praveena,

We have another template in review for our Pinterest Server 2 Server template.

https://github.com/cookieconsentio/gtm-pinterest-s2s-template

Can you also review this template?

We already created docs for the integration but are waiting for the approval of the template to also add this section to our docs:

https://www.cookieconsent.io/developers/

Can you please review our template? If there are any issues please let me know. Thank you.

Kind regards,

Jack Kwakman Senior Developer CookieConsent.io

cookieconsentio commented 1 year ago

Dear Praveena,

Can you check if our latest template 'Pinterest conversions API' is under review?

https://github.com/cookieconsentio/gtm-pinterest-s2s-template

We have submitted in three weeks ago and have not received any details about the evaluation. Can you please check for us?

Kind regards,

Jack Kwakman