cookiecutter-openedx / cookiecutter-openedx-devops

Open edX Tutor on Kubernetes implemented with Terraform
GNU Affero General Public License v3.0
41 stars 16 forks source link

Modify eks-auth map_roles to use rolearn instead of userarn #61

Closed Markonick closed 1 year ago

Markonick commented 1 year ago

According to [https://registry.terraform.io/modules/aidanmelen/eks-auth/aws/1.0.0], rolearn should be used instead

Type of Change

Resolves

Describe Changes

This change simply modifies the variable "map_roles" inside the variables.tffile to use rolearn instead of userarn.

lpm0073 commented 1 year ago

thanks for creating this PR @Markonick . It needs one more edit, to main.tf, to actually assign the value of var.map_role to the aws eks module's variable. See this example for map_users[] here

Markonick commented 1 year ago

Awesome yup, I missed this! Will add to the PR. Cheers!

Markonick commented 1 year ago

Done in 99a669d54c3221c866a21c505e9d57aa951e98d8