Open github-actions[bot] opened 3 months ago
django-storages 1.14.4 should be good according to https://github.com/jschneier/django-storages/pull/1444
@browniebroke you did some upstream work on DRF on this topic. Is it compatible with Django 5.1 or do we need to await a release?
I did add it to the CI and everything passes without any changes. At work, we've got our main project running Django 5.1 and DRF 3.15 and didn't notice any issues.
The only known incompatibility is that the current DRF 3.15 doesn't support LoginRequiredMiddleware
. It's fixed in the DRF master branch but currently unreleased.
@browniebroke I found an issue while running CI from Django 5.0.9 to 5.1.2.
If a project is generated with option username_type
to username
, the test TestUserAdmin.test_add
fails with an error like this:
django.core.exceptions.FieldError: Unknown field(s) (usable_password) specified for User. Check fields/fieldsets/exclude attributes of class UserAdmin.
This is caused by multiples changes in Django 5.1:
django/django#16942 django/django#18484
This change introduces a new field named usable_password
, and it can cause conflicts with customized UserAdminCreationForm
The new default value of UserAdmin.add_fieldsets
is this:
django/django/blob/263f7319192b217c4e3b1eea0ea7809836392bbc/django/contrib/auth/admin.py
When username_type
is username
the custom UserAdmin
doesn't change the field value, only if email
type is selected:
In Django documentation gives a possible solution: replace UserCreationForm
by AdminUserCreationForm
, but it was included in Django 5.1.1 and it requires update Django dependency version from series 5.0 to 5.1.
Yes we may have to adapt a few things, and thanks for sharing that, will be useful when we get to it.
5.1 requirements tables
base.txt
local.txt
production.txt