Closed Zethson closed 4 years ago
@filipdutescu Just added you here since we want to discuss this with you at some later point.
Draft is up on questionary branch.
PyInquirer is awful maintained and has some issues.
Questionary seems to be perfectly fine.
Mixing click and questionary results in weird behavior when echo -e <- it aborts after the questionary prompts. No damn clue why.
-> We would need to replace every click prompt with questionary prompts.
Think this would be fine, since it would to a more consistent style anyways.
@Imipenem
Only thing I dislike are the default values, but we can discuss that on Discord.
Just a note for me, we can easily code this ourselves.
def unsafe_ask(self, patch_stdout: bool = False) -> Any:
"""Ask the question synchronously and return user response.
Does not catch keyboard interrupts."""
if patch_stdout:
with prompt_toolkit.patch_stdout.patch_stdout():
return self.application.run()
else:
return self.application.run()
-> can also use the unsafe ask
I have to fix all workflows and tests to close this.
Now we have to figure out how to do the tests.
@Imipenem I doubt that we'll get an answer haha.
What was your "hardcore" mocking idea about the tests again?
And the respective advantages and disadvantages?
https://github.com/tmbo/questionary/issues/49#issuecomment-652574068
We got an answer and should discuss this over the next couple of days.
https://github.com/CITGuru/PyInquirer/blob/master/README.rst
Could make our click prompts and especially the choices much nicer and interactive.
Advantages and disadvantages when it comes to scaling.
Let's discuss this.