cooklang / cooklang-import

A command line tool to import recipes into Cooklang format
MIT License
33 stars 12 forks source link

Lack of parameters doesn't show usage #10

Closed nicholaswilde closed 2 years ago

nicholaswilde commented 2 years ago

When using the cook-import binary without any parameters, usage is not displayed.

Actual behavior:

~$ cook-import
Traceback (most recent call last):
  File "cook-import", line 25, in <module>
  File "recipe_scrapers/__init__.py", line 361, in scrape_me
  File "recipe_scrapers/_utils.py", line 116, in get_host_name
AttributeError: 'NoneType' object has no attribute 'replace'
[1639] Failed to execute script 'cook-import' due to unhandled exception!

Expected behavior:

~$ cook-import
usage: cook-import [-h] [--link LINK] [--file]

Automatically extract recipes from online websites.

optional arguments:
  -h, --help   show this help message and exit
  --link LINK  Input a url link to a recipe
  --file       If you want the output to be in a file, use this flag. Otherwise defaults to console screen.

Using cook-import --help does give the correct output and cook-import does behave normally.

Binary was compiled using the following command (from the GH action):

~$ poetry run pyinstaller cook-import.spec
~$ poetry --version
Poetry version 1.1.13
~$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.4 LTS
Release:        20.04
Codename:       focal
~$ python --version
Python 3.8.10