cookpad / global-style-guides

Official style guides for Cookpad Global
67 stars 16 forks source link

Avoid adding translation for single language experiments #172

Closed brunobrgs closed 3 years ago

brunobrgs commented 3 years ago

Follow up: https://github.com/cookpad/global-web/pull/21917

Translations that have been added to the yaml files notifies the translation team who will attempt to add a translation for the feature, if it is experimental and only needed for one language there is no need to add your translation to the yaml file.

artygus commented 3 years ago

Thinking out loud: would there be any value in having experiments.XX.yml files, that would not go into OneSky but allow us to centrally manage experiment translations without bothering translators?

Great option, covers the case when experiment might be extended to second language. From recent experience, changing hardcoded default values in multiple places is not fun 😢

jesseclark commented 3 years ago

Thinking out loud: would there be any value in having experiments.XX.yml files, that would not go into OneSky but allow us to centrally manage experiment translations without bothering translators?

This seems preferable to me over the default: approach and would also enable us to share the file with the translators for the language that we need translated for the experiment. The keys could then be moved from the experiments.en.yml to the main translation file when the experiment was going to be rolled out.

dannyd4315 commented 3 years ago

Thinking out loud: would there be any value in having experiments.XX.yml files, that would not go into OneSky but allow us to centrally manage experiment translations without bothering translators?

This seems preferable to me over the default: approach and would also enable us to share the file with the translators for the language that we need translated for the experiment. The keys could then be moved from the experiments.en.yml to the main translation file when the experiment was going to be rolled out.

Yeah I really like this idea as well 👍

balvig commented 3 years ago

Thinking out loud: would there be any value in having experiments.XX.yml files\

Nice, this sounds like a bonafide silver bullet to me 👏