cookpad / kuroko2

Kuroko2 is a web-based job scheduler / workflow engine.
MIT License
313 stars 72 forks source link

Alter {users,job_definitions}.id to bigint #117

Closed riseshia closed 6 years ago

riseshia commented 6 years ago

There is the problem that some tables has different type of primary key from its installed:

This problem was made by fa75b20e463f0f95d74aa3e50ac6b35e1596f26b.

This makes hard to keep consistency of code / infra. For instance, we need to care about 2 types of primary when adding foreign key. Actually, this is already blocker of https://github.com/cookpad/kuroko2/pull/110

To solve the problem, this patch proposes to alter these primary key to bigint, which is next default type of rails.

Please review this @cookpad/dev-infra cc @takonomura

eagletmt commented 6 years ago

Could you update spec/dummy/db/schema.rb by running the migration?

riseshia commented 6 years ago

Changed(rebased):