This option is no longer available on Rails 5.2 or newer, so we should remove the option to update Rails to v5.2.
This option changes Active Record's callbacks behavior if a callback returns false.
But I've confirmed the all AR callbacks in this project don't return false.
So we can remove this option safely.
By the way, I use kuroko2 with halt_callback_chains_on_return_false = false over 3 years, and we don't have any problem related to this option.
I got other errors by tests with Rails 5.2, so this pull request doesn't revert #112.
ref: https://github.com/cookpad/kuroko2/pull/112
This option is no longer available on Rails 5.2 or newer, so we should remove the option to update Rails to v5.2.
This option changes Active Record's callbacks behavior if a callback returns false. But I've confirmed the all AR callbacks in this project don't return false. So we can remove this option safely.
By the way, I use kuroko2 with
halt_callback_chains_on_return_false = falseover 3 years, and we don't have any problem related to this option.I got other errors by tests with Rails 5.2, so this pull request doesn't revert #112.