cookpad / kuroko2

Kuroko2 is a web-based job scheduler / workflow engine.
MIT License
313 stars 72 forks source link

Upgrade html-pipeline to v3 and drop support for Ruby <= 3.0 #156

Closed coord-e closed 7 months ago

coord-e commented 7 months ago

Current kuroko2 won't work with latest version (v3) of html-pipeline which contains a breaking change from v2. This PR contains changes to migrate kuroko2 to html-pipeline v3. This PR also fixes a spec which is broken by commonmarker v1.

I briefly confirmed proper rendering of job descriptions using local Kuroko2 instance.

@cookpad/infra could you please review?

coord-e commented 7 months ago

Hmm html-pipeline v3 requires Ruby ~> 3.1, so we need to bump minimum supported Ruby version. I think we can drop Ruby 2.7 and 3.0 because they're already / almost EOL. 8abe6195c0da10c6f6b286493b1a8cb09d61b39b