cookpad / sds

Envoy's v1 Service Discovery Service API and v2 Endpoint Discovery Service API
24 stars 4 forks source link

Consider using rustls vs. OpenSSL #13

Open moderation opened 5 years ago

moderation commented 5 years ago

I've been running sds as my Envoy control plane for a couple of months now and it has been great. One of the first things I did was switch to rustls vs. OpenSSL. I notice a large drop in binary size but more importantly sds used a lot less memory.

This tweet just reminded me about this - https://twitter.com/BRIAN_____/status/1146187144030896129

Rustls vs OpenSSL: (link: https://jbp.io/2019/07/01/rustls-vs-openssl-performance.html)

The only change required is in Cargo.toml

rusoto_dynamodb = { version = "0.40", default_features = false, features = ["rustls"] }

Happy to create a PR is this is of interest.

eagletmt commented 5 years ago

That sounds so cool! sds is already memory-efficient enough (in our environment, it uses about 5 - 10 MiB RAM), but improving the memory usage and binary size are highly welcomed. Could you create a PR?