cookpad / sds

Envoy's v1 Service Discovery Service API and v2 Endpoint Discovery Service API
24 stars 4 forks source link

Add skip_serializing_if field attr #3

Closed ganmacs closed 6 years ago

ganmacs commented 6 years ago

follow up https://github.com/cookpad/sds/pull/2

skip_serializing_if: https://serde.rs/field-attrs.html#serdeskipserializingif--path

Returning the value of load_balancing_weight as null is not acceptable for envoy. it's only acceptable number(1-100) or nothing. https://www.envoyproxy.io/docs/envoy/latest/api-v1/cluster_manager/sds#host-json

@cookpad/dev-infra review please 🙏