search

cookpete / react-player

A React component for playing a variety of URLs, including file paths, YouTube, Facebook, Twitch, SoundCloud, Streamable, Vimeo, Wistia and DailyMotion
https://cookpete.github.io/react-player
MIT License
8.89k stars 1.12k forks source link

Critical dependency: the request of a dependency is an expression #1755

Closed hoantran-it closed 2 months ago

hoantran-it commented 2 months ago

The latest update introduces this issue

WARNING in ./node_modules/react-player/lib/players/Mux.js 136:14-64
Critical dependency: the request of a dependency is an expression

Could we disable it?

hemantgogia09 commented 2 months ago

seeing the same thing with 2.15.0

luwes commented 2 months ago

which framework / build tool are you using?

hemantgogia09 commented 2 months ago

This is some of the libraries that i think useful to know if you think i missed some important ones let me know

"react": "18.2.0", "react-dom": "^18.2.0",

"eslint": "^8.56.0", "eslint-config-airbnb": "^19.0.4", "eslint-plugin-import": "^2.29.1", "eslint-plugin-jsx-a11y": "^6.8.0", "eslint-plugin-react": "^7.33.2", "webpack": "^5.89.0", "webpack-cli": "^5.1.4", "webpack-dev-server": "^4.15.1"

ps250551 commented 2 months ago

We are seeing this as well, but only in our github runner Screenshot 2024-03-01 at 4 39 10 PM

hoantran-it commented 2 months ago

which framework / build tool are you using?

I'm using create-react-app

luwes commented 2 months ago

should be fixed in v2.15.1. let me know otherwise!

hoantran-it commented 2 months ago

should be fixed in v2.15.1. let me know otherwise!

awesome, thanks @luwes 👍