cookpete / react-player

A React component for playing a variety of URLs, including file paths, YouTube, Facebook, Twitch, SoundCloud, Streamable, Vimeo, Wistia and DailyMotion
https://cookpete.github.io/react-player
MIT License
8.89k stars 1.12k forks source link

`onDuration` event no longer fires for HLS videos hosted by Mux in 2.15.1 #1763

Closed eikonomega closed 1 month ago

eikonomega commented 2 months ago

Current Behavior

After the implementation of automatically using the Mux player for videos hosted on Mux, the onDuration event is no longer fired on iOS devices.

Expected Behavior

While I understand, and even appreciate the desire to automatically use the mux-player for mux hosted videos, this seems like it is pretty clear breaking change that should have necessitated a major SEMVER version and associated documentation. As it is, it broke an application of ours that was set to automatically accept 2.X versions of the package.

Using the mux player should be opt-in for the 2.X series or onDuration should continue to function as before. At a minimum, documentation should be provided on how to opt-out and continue to use the previous (file?) player.

Appreciate all your work.

Thanks!

Steps to Reproduce

  1. Update from 2.14.1 to 2.15.1
  2. Have a ReactPlayer element with a url that points to a Mux hosted video.
  3. Add an onDuration handler to your element.
  4. It won't be triggered on iOS devices.

Environment