cookyshi / libjingle

Automatically exported from code.google.com/p/libjingle
0 stars 0 forks source link

‘EXPECT_TRUE_M’ was not declared in this scope #248

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Build the libjingle 0.6.3 with in ubuntu 10.10
2.
3.

What is the expected output? What do you see instead?
Successful build
instead i see the following error
In file included from session/phone/devicemanager_unittest.cc:42:
/home/krish/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:38: fatal 
error: testing/base/include/gmock.h: No such file or directory
compilation terminated.
scons: *** [build/dbg/obj/session/phone/devicemanager_unittest.o] Error 1
scons: building terminated because of errors.

What version of the product are you using? On what operating system?
libjingle.0.6.3
ubuntu 10.10

Please provide any additional information below.
#include "testing/base/include/gmock.h"

This directory is not in the package,
if i comment the line i get the following error,

_______Compiling build/dbg/obj/session/phone/devicemanager_unittest.o
In file included from session/phone/devicemanager_unittest.cc:42:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool talk_base::FakeFileSystem::CreatePrivateFile(const 
talk_base::Pathname&)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:173: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool talk_base::FakeFileSystem::DeleteFile(const 
talk_base::Pathname&)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:177: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool talk_base::FakeFileSystem::DeleteEmptyFolder(const 
talk_base::Pathname&)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:181: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool talk_base::FakeFileSystem::DeleteFolderContents(const 
talk_base::Pathname&)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:185: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool 
talk_base::FakeFileSystem::DeleteFolderAndContents(const 
talk_base::Pathname&)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:189: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool talk_base::FakeFileSystem::CreateFolder(const 
talk_base::Pathname&)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:193: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool talk_base::FakeFileSystem::MoveFolder(const 
talk_base::Pathname&, const talk_base::Pathname&)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:197: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool talk_base::FakeFileSystem::MoveFile(const 
talk_base::Pathname&, const talk_base::Pathname&)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:201: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool talk_base::FakeFileSystem::CopyFile(const 
talk_base::Pathname&, const talk_base::Pathname&)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:205: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool talk_base::FakeFileSystem::IsFolder(const 
talk_base::Pathname&)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:209: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool talk_base::FakeFileSystem::IsFile(const 
talk_base::Pathname&)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:213: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool talk_base::FakeFileSystem::IsAbsent(const 
talk_base::Pathname&)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:217: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool talk_base::FakeFileSystem::IsTemporaryPath(const 
talk_base::Pathname&)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:221: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool 
talk_base::FakeFileSystem::GetTemporaryFolder(talk_base::Pathname&, bool, const 
std::string*)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:226: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual std::string talk_base::FakeFileSystem::TempFilename(const 
talk_base::Pathname&, const std::string&)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:230: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool talk_base::FakeFileSystem::GetFileSize(const 
talk_base::Pathname&, size_t*)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:234: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool talk_base::FakeFileSystem::GetFileTime(const 
talk_base::Pathname&, talk_base::FileTimeType, time_t*)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:239: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool 
talk_base::FakeFileSystem::GetAppPathname(talk_base::Pathname*)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:243: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool 
talk_base::FakeFileSystem::GetAppDataFolder(talk_base::Pathname*, bool)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:247: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool 
talk_base::FakeFileSystem::GetAppTempFolder(talk_base::Pathname*)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:256: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h: In member 
function ‘virtual bool talk_base::FakeFileSystem::GetDiskFreeSpace(const 
talk_base::Pathname&, int64*)’:
/home/kishore/Desktop/src/libjingle-0.6.3/talk/base/fileutils_mock.h:260: 
error: ‘EXPECT_TRUE_M’ was not declared in this scope
scons: *** [build/dbg/obj/session/phone/devicemanager_unittest.o] Error 1
scons: building terminated because of errors.

Original issue reported on code.google.com by manohara...@gmail.com on 30 Nov 2011 at 10:08

GoogleCodeExporter commented 9 years ago
Added #define EXPECT_TRUE_M(x, y) to the code and it compiled past this.
Now into 

________Compiling build/dbg/obj/session/phone/devicemanager_unittest.o
________Compiling build/dbg/obj/session/phone/dummydevicemanager_unittest.o
________Compiling build/dbg/obj/session/phone/filemediaengine_unittest.o
________Compiling build/dbg/obj/session/phone/filevideocapturer_unittest.o
________Compiling build/dbg/obj/session/phone/mediamessages_unittest.o
________Compiling build/dbg/obj/session/phone/mediasession_unittest.o
session/phone/mediasession_unittest.cc: In member function ‘virtual void 
MediaSessionDescriptionFactoryTest_TestCreateAudioOffer_Test::TestBody()’:
session/phone/mediasession_unittest.cc:129:3: error: converting ‘false’ to 
pointer type for argument 1 of ‘char 
testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ 
[-Werror=conversion-null]
session/phone/mediasession_unittest.cc: In member function ‘virtual void 
MediaSessionDescriptionFactoryTest_TestCreateVideoOffer_Test::TestBody()’:
session/phone/mediasession_unittest.cc:155:3: error: converting ‘false’ to 
pointer type for argument 1 of ‘char 
testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ 
[-Werror=conversion-null]
session/phone/mediasession_unittest.cc:161:3: error: converting ‘false’ to 
pointer type for argument 1 of ‘char 
testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ 
[-Werror=conversion-null]
session/phone/mediasession_unittest.cc: In member function ‘virtual void 
MediaSessionDescriptionFactoryTest_TestCreateAudioAnswer_Test::TestBody()’:
session/phone/mediasession_unittest.cc:185:3: error: converting ‘false’ to 
pointer type for argument 1 of ‘char 
testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ 
[-Werror=conversion-null]
session/phone/mediasession_unittest.cc: In member function ‘virtual void 
MediaSessionDescriptionFactoryTest_TestCreateVideoAnswer_Test::TestBody()’:
session/phone/mediasession_unittest.cc:213:3: error: converting ‘false’ to 
pointer type for argument 1 of ‘char 
testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ 
[-Werror=conversion-null]
session/phone/mediasession_unittest.cc:218:3: error: converting ‘false’ to 
pointer type for argument 1 of ‘char 
testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ 
[-Werror=conversion-null]
cc1plus: all warnings being treated as errors

Original comment by mrco...@gmail.com on 3 Dec 2011 at 1:18

GoogleCodeExporter commented 9 years ago
I think this is the same issue as 
http://code.google.com/p/libjingle/issues/detail?id=238

The tests all seem very loosely packaged

Original comment by mrco...@gmail.com on 3 Dec 2011 at 1:25

GoogleCodeExporter commented 9 years ago
Removed the failing tests for ASSERT_CRYPTO in mediasession_unittest.cc 
Then hit

~/lib/libjingle-0.6.3/talk$ hammer.sh 
scons: Reading SConscript files ...

scons: warning: No installed VCs
File 
"/home/anton/lib/swtoolkit/site_scons/site_tools/target_platform_windows.py", 
line 283, in generate

scons: warning: No version of Visual Studio compiler found - C/C++ compilers 
most likely not set correctly
File 
"/home/anton/lib/swtoolkit/site_scons/site_tools/target_platform_windows.py", 
line 283, in generate

scons: warning: The build_dir keyword has been deprecated; use the variant_dir 
keyword instead.
File "/home/anton/lib/swtoolkit/site_scons/site_init.py", line 203, in 
BuildEnvironmentSConscripts
scons: done reading SConscript files.
scons: Building targets ...
scons: `all_libraries' is up to date.
scons: `all_programs' is up to date.
________Compiling build/dbg/obj/session/phone/mediasession_unittest.o
________Compiling build/dbg/obj/session/phone/rtpdump_unittest.o
________Compiling build/dbg/obj/session/phone/rtputils_unittest.o
________Compiling build/dbg/obj/session/phone/srtpfilter_unittest.o
session/phone/srtpfilter_unittest.cc:35:52: fatal error: 
third_party/libsrtp/crypto/include/err.h: No such file or directory
compilation terminated.
scons: *** [build/dbg/obj/session/phone/srtpfilter_unittest.o] Error 1
scons: building terminated because of errors.

CHANGED #include "third_party/libsrtp/crypto/include/err.h" 
TO      #include "third_party/srtp/crypto/include/err.h" 

Final output 

scons: Reading SConscript files ...

scons: warning: No installed VCs
File 
"/home/anton/lib/swtoolkit/site_scons/site_tools/target_platform_windows.py", 
line 283, in generate

scons: warning: No version of Visual Studio compiler found - C/C++ compilers 
most likely not set correctly
File 
"/home/anton/lib/swtoolkit/site_scons/site_tools/target_platform_windows.py", 
line 283, in generate

scons: warning: The build_dir keyword has been deprecated; use the variant_dir 
keyword instead.
File "/home/anton/lib/swtoolkit/site_scons/site_init.py", line 203, in 
BuildEnvironmentSConscripts
scons: done reading SConscript files.
scons: Building targets ...
scons: `all_libraries' is up to date.
scons: `all_programs' is up to date.
________Compiling build/dbg/obj/session/phone/srtpfilter_unittest.o
________Compiling build/dbg/obj/session/phone/testutils.o
________Compiling build/dbg/obj/session/phone/videocapturer_unittest.o
________Compiling build/dbg/obj/session/phone/videocommon_unittest.o
________Linking build/dbg/obj/media_unittest
Install file: "build/dbg/obj/media_unittest" as "build/dbg/tests/media_unittest"
scons: done building targets.

Original comment by mrco...@gmail.com on 3 Dec 2011 at 1:50

GoogleCodeExporter commented 9 years ago

Original comment by juberti@google.com on 21 Dec 2011 at 11:20

GoogleCodeExporter commented 9 years ago

Original comment by jun...@google.com on 21 Dec 2011 at 11:25

GoogleCodeExporter commented 9 years ago
It's fixed. Should be in the next release 0.6.7.

Original comment by jun...@google.com on 22 Dec 2011 at 10:04

GoogleCodeExporter commented 9 years ago
When is release 0.6.7 coming out?

Original comment by claudioo...@gmail.com on 8 Jan 2012 at 4:23