Closed GoogleCodeExporter closed 9 years ago
Added #define EXPECT_TRUE_M(x, y) to the code and it compiled past this.
Now into
________Compiling build/dbg/obj/session/phone/devicemanager_unittest.o
________Compiling build/dbg/obj/session/phone/dummydevicemanager_unittest.o
________Compiling build/dbg/obj/session/phone/filemediaengine_unittest.o
________Compiling build/dbg/obj/session/phone/filevideocapturer_unittest.o
________Compiling build/dbg/obj/session/phone/mediamessages_unittest.o
________Compiling build/dbg/obj/session/phone/mediasession_unittest.o
session/phone/mediasession_unittest.cc: In member function ‘virtual void
MediaSessionDescriptionFactoryTest_TestCreateAudioOffer_Test::TestBody()’:
session/phone/mediasession_unittest.cc:129:3: error: converting ‘false’ to
pointer type for argument 1 of ‘char
testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’
[-Werror=conversion-null]
session/phone/mediasession_unittest.cc: In member function ‘virtual void
MediaSessionDescriptionFactoryTest_TestCreateVideoOffer_Test::TestBody()’:
session/phone/mediasession_unittest.cc:155:3: error: converting ‘false’ to
pointer type for argument 1 of ‘char
testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’
[-Werror=conversion-null]
session/phone/mediasession_unittest.cc:161:3: error: converting ‘false’ to
pointer type for argument 1 of ‘char
testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’
[-Werror=conversion-null]
session/phone/mediasession_unittest.cc: In member function ‘virtual void
MediaSessionDescriptionFactoryTest_TestCreateAudioAnswer_Test::TestBody()’:
session/phone/mediasession_unittest.cc:185:3: error: converting ‘false’ to
pointer type for argument 1 of ‘char
testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’
[-Werror=conversion-null]
session/phone/mediasession_unittest.cc: In member function ‘virtual void
MediaSessionDescriptionFactoryTest_TestCreateVideoAnswer_Test::TestBody()’:
session/phone/mediasession_unittest.cc:213:3: error: converting ‘false’ to
pointer type for argument 1 of ‘char
testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’
[-Werror=conversion-null]
session/phone/mediasession_unittest.cc:218:3: error: converting ‘false’ to
pointer type for argument 1 of ‘char
testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’
[-Werror=conversion-null]
cc1plus: all warnings being treated as errors
Original comment by mrco...@gmail.com
on 3 Dec 2011 at 1:18
I think this is the same issue as
http://code.google.com/p/libjingle/issues/detail?id=238
The tests all seem very loosely packaged
Original comment by mrco...@gmail.com
on 3 Dec 2011 at 1:25
Removed the failing tests for ASSERT_CRYPTO in mediasession_unittest.cc
Then hit
~/lib/libjingle-0.6.3/talk$ hammer.sh
scons: Reading SConscript files ...
scons: warning: No installed VCs
File
"/home/anton/lib/swtoolkit/site_scons/site_tools/target_platform_windows.py",
line 283, in generate
scons: warning: No version of Visual Studio compiler found - C/C++ compilers
most likely not set correctly
File
"/home/anton/lib/swtoolkit/site_scons/site_tools/target_platform_windows.py",
line 283, in generate
scons: warning: The build_dir keyword has been deprecated; use the variant_dir
keyword instead.
File "/home/anton/lib/swtoolkit/site_scons/site_init.py", line 203, in
BuildEnvironmentSConscripts
scons: done reading SConscript files.
scons: Building targets ...
scons: `all_libraries' is up to date.
scons: `all_programs' is up to date.
________Compiling build/dbg/obj/session/phone/mediasession_unittest.o
________Compiling build/dbg/obj/session/phone/rtpdump_unittest.o
________Compiling build/dbg/obj/session/phone/rtputils_unittest.o
________Compiling build/dbg/obj/session/phone/srtpfilter_unittest.o
session/phone/srtpfilter_unittest.cc:35:52: fatal error:
third_party/libsrtp/crypto/include/err.h: No such file or directory
compilation terminated.
scons: *** [build/dbg/obj/session/phone/srtpfilter_unittest.o] Error 1
scons: building terminated because of errors.
CHANGED #include "third_party/libsrtp/crypto/include/err.h"
TO #include "third_party/srtp/crypto/include/err.h"
Final output
scons: Reading SConscript files ...
scons: warning: No installed VCs
File
"/home/anton/lib/swtoolkit/site_scons/site_tools/target_platform_windows.py",
line 283, in generate
scons: warning: No version of Visual Studio compiler found - C/C++ compilers
most likely not set correctly
File
"/home/anton/lib/swtoolkit/site_scons/site_tools/target_platform_windows.py",
line 283, in generate
scons: warning: The build_dir keyword has been deprecated; use the variant_dir
keyword instead.
File "/home/anton/lib/swtoolkit/site_scons/site_init.py", line 203, in
BuildEnvironmentSConscripts
scons: done reading SConscript files.
scons: Building targets ...
scons: `all_libraries' is up to date.
scons: `all_programs' is up to date.
________Compiling build/dbg/obj/session/phone/srtpfilter_unittest.o
________Compiling build/dbg/obj/session/phone/testutils.o
________Compiling build/dbg/obj/session/phone/videocapturer_unittest.o
________Compiling build/dbg/obj/session/phone/videocommon_unittest.o
________Linking build/dbg/obj/media_unittest
Install file: "build/dbg/obj/media_unittest" as "build/dbg/tests/media_unittest"
scons: done building targets.
Original comment by mrco...@gmail.com
on 3 Dec 2011 at 1:50
Original comment by juberti@google.com
on 21 Dec 2011 at 11:20
Original comment by jun...@google.com
on 21 Dec 2011 at 11:25
It's fixed. Should be in the next release 0.6.7.
Original comment by jun...@google.com
on 22 Dec 2011 at 10:04
When is release 0.6.7 coming out?
Original comment by claudioo...@gmail.com
on 8 Jan 2012 at 4:23
Original issue reported on code.google.com by
manohara...@gmail.com
on 30 Nov 2011 at 10:08