Closed itraviv closed 4 years ago
This looks excellent to me.
Two small notes:
[False, True, ]
should be (False, True)
except NotImplementedError
you should use pytest.raises
.@alexmojaki if you feel like taking a look, feel free, if you're busy that's cool.
Wait, another note. Looking at the normalized output, I don't like how the code is now aligned with the variable changes. It's confusing. So when there's no datetime, instead of ''
, please use ' ' * 15
. That way the alignment is preserved. I guess you'll need to change the tests a bit too. Please do all these changes in separate commits than what you've submitted so far, so I could easily compare them.
Good, the only thing that's left is that [False, True, ]
should be (False, True)
i swear it was there! 😒
Can you change it from (True, False, )
to (True, False)
?
Can you change it from
(True, False, )
to(True, False)
?
sure
@alexmojaki Let me know whether you have time to give it a look before I merge. (I'll squash Itamar's commits.)
Go ahead.
I squashed these commits separately and made a release, adding Itamar to the authors file. Congrats on your first contribution!
thanks!
normalizing output - removing machine specific data:
tests:
readme: