search

cool-RR / PySnooper

Never use print for debugging again
MIT License
16.37k stars 951 forks source link

Revised some indent, typo and added function of printing in color. #208

Closed yunminjin2 closed 3 years ago

yunminjin2 commented 3 years ago

Our 20-2-SKKU-OSS Team has studied your code. However, we had revised some mistakes. We thought that it would be easy to see if there could be divided in color. For example, time, fuction name, code, return, variable text could be divided in different color.

I hope it would be helpful!

Thank you. Pysnooper_color

cool-RR commented 3 years ago

Guys, you clearly worked hard on this and you have a desire to contribute. But you're not careful enough and not communicative enough. Please remember that we are volunteers who are reviewing your code in our spare time.

You sent us a diff that's 80% irrelevant changes so it's difficult to find your contributions. You didn't discuss the design with us before doing all this work. You made puzzling changes like this one which lower the code quality for no good reason. You changed indentation of existing lines, committed IDE-specific code which should stay out of the repo, etc.

As Alex said, color must be optional and we must be careful not to cause problem on any platforms.

Right now the way you're contributing is causing a bigger burden on us than just implementing the features ourselves. Either change your approach completely or please find another project to contribute to.

yunminjin2 commented 3 years ago

I'm sorry about giving you confusion. Actually we're just students learning Open Source Project for first time. For a study, we have selected your projects. Because we're not professional software engineer, there would be a lot of problems... I agree. Don't care a lot of our Pull&Request. Sorry for bothering you.

However, it was a great project to study. We could learn a lot like pull&request, commit, version control, considering different platform. Thank you for giving us a chance to study with.

Have a good day!

laike9m commented 3 years ago

I'm sorry about giving you confusion. Actually we're just students learning Open Source Project for first time. For a study, we have selected your projects. Because we're not professional software engineer, there would be a lot of problems... I agree. Don't care a lot of our Pull&Request. Sorry for bothering you.

However, it was a great project to study. We could learn a lot like pull&request, commit, version control, considering different platform. Thank you for giving us a chance to study with.

Have a good day!

This is very unprofessional and disrespectful behavior. If you want to be software engineers in the future, please don't do this. This kind of PR is pure spam.