search

coolOrangeLabs / powerGateTemplate

powerGate full functional sample ERP integration
MIT License
3 stars 3 forks source link

Clicking twice on "Check" in the BomWindow "BOM" tab makes problems #190

Closed georgschwienbacher closed 2 years ago

georgschwienbacher commented 3 years ago

Apply the same solution for pG Template here like we did in https://github.com/coolOrangeProjects/Hauer/commit/ffbf01cdd3c364d55033beb8b976c39534251f31

We had several issues in the past:

PatrickGrub commented 3 years ago

Yes, its the very same situation twice and it makes sense to implement it in the template!

ThomasRossmeisl commented 2 years ago

Can't fully understand the issue as there is no description, but if this is about bomrows in state "remove" causing errors on repeated presses of the "Check" button the solution would be to use Remove-BomWindowEntity to remove them again. Generally if an Add-BomWindowEntity is used within the checkfunction the developer also has to add code to the start of the Check-Boms function to remove them again with Remove-BomWindowEntity.

Simply updating them like in Hauer will not fix this issue

manuelcassan commented 2 years ago

If there is an Add-BomWindowEntity in the Check-Boms function it causes issues when clicking the "Check" button multiple times. This should be prevented in the Check-Boms function by using Remove-BomWindowEntity at the beginning of the function and make sure that the entities in the BOM dialog are the same as when the BOM dialog was first opened.

StefanNairz commented 2 years ago

Same issue as in issue 188 (already solved)