search

coolOrangeLabs / powerGateTemplate

powerGate full functional sample ERP integration
MIT License
3 stars 3 forks source link

powerEvents to validate the ERP BOM on release #35

Closed christiangessner closed 4 years ago

christiangessner commented 4 years ago

Bei der Freigabe soll die BOM „validiert“ werden. Im Moment wird über powerEvents der Artikel „validiert“. Das sollte im Template mit aufgenommen werden, da es ein recht übliches und gut angesehenes Feature ist

christiangessner commented 4 years ago

check if the BOM exists in ERP and if it's identical with the Vault file/item BOM (same as BOM window would check) block the state transition if it's not identical

PatrickGrub commented 4 years ago

This was already implemented in the fileMaster in a project recently by @HannesDosser you can find all information and the code related to [this Github Issue(https://github.com/coolOrangeProjects/Sollich/issues/210):

manfredmalleier commented 4 years ago

Issue was implemented. However, I recommend to refactor some functions (for instance GetEntityNumber) from powerGateMain.ps1 to a module used by both powerEvents and powerGate. Currently powerGateMain.ps1 is included directly in powerEvents/modules/Import.Modules.psm1 to be used in powerEvents.

PatrickGrub commented 4 years ago

Mentioned recommended refactor (see above) needs to be done for closing this issue

christiangessner commented 4 years ago

Refactoring complete: b99494f