Rare FC after many orientation flips and get more datas on BookSearch

[GoogleCodeExporter]

FCs on BookSearch are very rare now after recent changes. Nevertheless, still 
can get one if I try really hard:

E/AndroidRuntime( 7011): FATAL EXCEPTION: main
E/AndroidRuntime( 7011): java.lang.IndexOutOfBoundsException: Invalid index 
119, size is 90
E/AndroidRuntime( 7011):    at 
java.util.ArrayList.throwIndexOutOfBoundsException(ArrayList.java:257)
E/AndroidRuntime( 7011):    at java.util.ArrayList.get(ArrayList.java:311)
E/AndroidRuntime( 7011):    at 
com.totsp.bookworm.BookSearch$3.onItemClick(BookSearch.java:99)
E/AndroidRuntime( 7011):    at 
android.widget.AdapterView.performItemClick(AdapterView.java:284)
E/AndroidRuntime( 7011):    at 
android.widget.ListView.performItemClick(ListView.java:3382)
E/AndroidRuntime( 7011):    at 
android.widget.AbsListView$PerformClick.run(AbsListView.java:1696)
E/AndroidRuntime( 7011):    at android.os.Handler.handleCallback(Handler.java:587)
E/AndroidRuntime( 7011):    at android.os.Handler.dispatchMessage(Handler.java:92)
E/AndroidRuntime( 7011):    at android.os.Looper.loop(Looper.java:123)
E/AndroidRuntime( 7011):    at 
android.app.ActivityThread.main(ActivityThread.java:4627)
E/AndroidRuntime( 7011):    at java.lang.reflect.Method.invokeNative(Native 
Method)
E/AndroidRuntime( 7011):    at java.lang.reflect.Method.invoke(Method.java:521)
E/AndroidRuntime( 7011):    at 
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:868)
E/AndroidRuntime( 7011):    at 
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:626)
E/AndroidRuntime( 7011):    at dalvik.system.NativeStart.main(Native Method)
W/ActivityManager(   83):   Force finishing activity 
com.totsp.bookworm/.BookSearch
W/ActivityManager(   83): Activity pause timeout for HistoryRecord{44e449d8 
com.totsp.bookworm/.BookSearch}

Original issue reported on code.google.com by charlie....@gmail.com on 10 Jun 2010 at 5:49

[GoogleCodeExporter]

Note you can also currently (with SVN head code, not with release code) select 
a book from the search results activity and end up with the wrong book on the 
results activity. Somehow the index is off (and clicking on items way down in 
the list that don't have a mixed up selection, results in error above).

Original comment by charlie....@gmail.com on 11 Jun 2010 at 2:45

• Added labels: Priority-Critical
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Original comment by charlie....@gmail.com on 11 Jun 2010 at 2:46

• Added labels: 1.0.13

[GoogleCodeExporter]

Stack trace after other code changes today

E/AndroidRuntime(14868): java.lang.IndexOutOfBoundsException: Invalid index 87, 
size is 40
E/AndroidRuntime(14868):    at 
java.util.ArrayList.throwIndexOutOfBoundsException(ArrayList.java:257)
E/AndroidRuntime(14868):    at java.util.ArrayList.get(ArrayList.java:311)
E/AndroidRuntime(14868):    at 
com.totsp.bookworm.BookSearch$3.onItemClick(BookSearch.java:99)
E/AndroidRuntime(14868):    at 
android.widget.AdapterView.performItemClick(AdapterView.java:284)
E/AndroidRuntime(14868):    at 
android.widget.ListView.performItemClick(ListView.java:3382)
E/AndroidRuntime(14868):    at 
android.widget.AbsListView$PerformClick.run(AbsListView.java:1696)
E/AndroidRuntime(14868):    at android.os.Handler.handleCallback(Handler.java:587)
E/AndroidRuntime(14868):    at android.os.Handler.dispatchMessage(Handler.java:92)
E/AndroidRuntime(14868):    at android.os.Looper.loop(Looper.java:123)
E/AndroidRuntime(14868):    at 
android.app.ActivityThread.main(ActivityThread.java:4627)
E/AndroidRuntime(14868):    at java.lang.reflect.Method.invokeNative(Native 
Method)
E/AndroidRuntime(14868):    at java.lang.reflect.Method.invoke(Method.java:521)
E/AndroidRuntime(14868):    at 
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:868)
E/AndroidRuntime(14868):    at 
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:626)
E/AndroidRuntime(14868):    at dalvik.system.NativeStart.main(Native Method)
W/ActivityManager(   83):   Force finishing activity 
com.totsp.bookworm/.BookSearch

Original comment by charlie....@gmail.com on 13 Jun 2010 at 12:59

[GoogleCodeExporter]

Found bug, not selected from adapter on booksearch (selecting from parsed books 
array used to pop adapter after recent changes, just need to use adapter).

Original comment by charlie....@gmail.com on 13 Jun 2010 at 1:07

• Changed state: Fixed