search

coolaj86 / TextEncoderLite_tmp

Polyfill for the Encoding Living Standard's API
Apache License 2.0
30 stars 19 forks source link

make it work properly in npm #2

Closed whmountains closed 7 years ago

whmountains commented 7 years ago

Normally you can access a module installed with npm like this:

require('text-decoder-lite')

But right now this doesn't work because your code doesn't define it's exports. There's no way to access it when installed with npm. This change fixes that.

coolaj86 commented 7 years ago

Sorry for the long wait. I gave you collab access so you can merge this.

Give me your npm username and I'll add you as an owner so you can publish the new version.

Ruffio commented 7 years ago

Is this going to be merged?

coolaj86 commented 7 years ago

@Ruffio same deal for you. Tell me you want collab access and npm publish rights and they're yours.

Ruffio commented 7 years ago

@coolaj86 thanks, but I think it is better/safer that I don't get collab :-) I'm too old fashion, currently I'm only using Bower as long as possible... :-)

vitalets commented 6 years ago

Hi! Please, publish it to npm as current 1.0.0 is unusable. I can help with publishing if you provide access.

Ruffio commented 6 years ago

@coolaj86 give me npm access and I will fix it