search

coolaj86 / TextEncoderLite_tmp

Polyfill for the Encoding Living Standard's API
Apache License 2.0
30 stars 19 forks source link

When using Bower, it would be nice with a min version of the js file #4

Closed Ruffio closed 6 years ago

coolaj86 commented 7 years ago

P.S. This isn't even my project. How did I end up getting MRs on my fork of someone else's deal?

Hmm... I guess I must have published it after them not responding to an MR or something.

Nevertheless, whatever works.

Ruffio commented 7 years ago

What do you mean by this isn't your project? It is your fork... Personally I want to use this instead of the master fork as this is much lighter and I'm only interested in utf8. I would have written an issue/suggestion to you about making it a polyfill, so if the browser doesn't support TextEncoder then this would kick in instead. The result would be that if the browser natively supported TextEncoder then that would be used but if not, then this 'project' would be used instead. In that way one can write code as if all browsers has the TextEncoder implemented. I just think that this is too far from your fork as it would break existing implementations that uses the TextEncoderLite instead of TextEncoder.

Ruffio commented 7 years ago

Using https://jscompress.com/ the code can be compressed to 1.36 KB. Wow that is really nothing :-)

coolaj86 commented 7 years ago

Ah, I see what I did here. I probably forked his code in the beginning but then ended up going a different direction and never unlinked the fork.

Please feel free to add the minified version. I think I sent you a collab invite.

Ruffio commented 6 years ago

@coolaj86 thanks for the review and merge :-) I don't see the changes. Do you need to update it there or do something?

coolaj86 commented 6 years ago

Where do you not see the changes? github (I see them)? bower (probably need to push a git tag...)? npm (not updated yet)?

coolaj86 commented 6 years ago

I just pushed a git tag for bower. And republished on npm.

Ruffio commented 6 years ago

Cool, thanks. I see it :-) image