coolapso / hugo-theme-terminalcv

An easy to setup and (almost) fully customizable command line style CV theme for HUGO
MIT License
108 stars 21 forks source link

term.typing results in undefined messages #17

Open davidem opened 3 weeks ago

davidem commented 3 weeks ago

Hi, I see you changed from jquery.terminal 2.35.1 to 2.42.0.

Unfortunately term.typing results in a massive spam of undefined messages when using the new version.

This is with 2.42.0 set in head.html: https://github.com/coolapso/hugo-theme-terminalcv/assets/706591/f3194252-38dd-47be-8500-54a28735a2d3

This is with 2.35.1 set in head.html: https://github.com/coolapso/hugo-theme-terminalcv/assets/706591/8b8cbc4c-f648-4140-bf90-5626a0506fb4

I call term.typing like this: term.typing('echo', 5, '{{ .Site.Params.bootsequence9 }}', function() { });

Bootsequence parameter:

  bootsequence9: |
    [OSBoot1]
    [OSBoot2]
    [OSBoot3]
    [OSBootTheme]

    Boot Complete

I assume this is not because of your rework, but I thought to ask first here.

coolapso commented 3 weeks ago

At glance it doesn't look related by my changes to the theme, but I can't fully exclude it ... do you have a fork I can look into?

davidem commented 3 weeks ago

yes, here it is: https://github.com/davidem/terminalcv_test

coolapso commented 3 weeks ago

What I want to look at is the changes to the theme. The repo you sent is missing the gitm modules configuration. there's no link to a git module

davidem commented 3 weeks ago

My bad... please check again 😉

davidem commented 1 week ago

Have you had a chance to look? :)

coolapso commented 1 week ago

Hi, I am sorry this has completely slipped through, i'll see if I have time to take a look at it sometime this week or during the weekend.

coolapso commented 5 days ago

:thinking: either I am misisng something or I don't see anything wrong ....

https://github.com/coolapso/hugo-theme-terminalcv/assets/14358086/e8f0d243-ac86-4dcf-9fbf-41f8e66e5041

davidem commented 4 days ago

v2.35.1 is currently selected, which works. Please switch to 2.42.0 in themes/terminalcv/layouts/partials/head.html:

Screenshot 2024-07-01 at 15 01 57