coolbho3k / manuf

Parser library for Wireshark's OUI database.
Other
120 stars 36 forks source link

Published the module to AUR #25

Open codeswhite opened 4 years ago

codeswhite commented 4 years ago

Edited the readme to include a new installation method via Arch User Repository Thus allowing every Arch-based distro user to easily install the module as a system package.

Feel free to contact me in any case.

tristanlatr commented 4 years ago

Hi,

Thanks for this ! Checked the shasum of python sources files, looks legit.

I don't know much about Arch Linux... Why do we need to upload it to another package repository ? pip is not working on Arch Linux ?

Other question: what would be the process / script for publishing new releases to AUR ? Could you add little bit of comments in setup.py to document this process please.

Also, the LICENSE.txt is missing from package source uploaded to AUR (https://files.pythonhosted.org/packages/9e/cf/354dddc57508194082c74310dec15341c008d47b7d37fd813d7fb0c46349/manuf-1.1.1.tar.gz). Since it's a funky license style, that would be a good idea to include it.

Anyway, sorry for all the questions/demands and thanks again :)

tristanlatr commented 4 years ago

Might not be possible to edit and add LICENSE.txt to source files without changing version number tho...

codeswhite commented 4 years ago

I'm glad you have questions, will try to answer them as possible,

Why?

Updates Frequency Arch is a rolling-release distro meaning we get updates frequently and quickly so Arch users performs full system upgrade more frequently (pacman -Syu equivalent to apt update && apt upgrade) . So packaging a python module to AUR will allow Arch users to stay constantly updated.

System Integrity Keeping track of all files on the disk is great for many reasons, its even better when the system package manager (pacman) does it for you! Having manuf along with its (non-existing) python dependencies packaged as a system packages on AUR allows to have all of their files tracked.

How?

The process is quite straight-forward:

Traditional actions:

Now PKGBUILD is basically a blueprint for building and installing a piece of software, see PKGBUILD Prototype and Submitting a package to AUR to take a look at the process.


Might not be possible to edit and add LICENSE.txt to source files without changing version number tho...

As about that.. I guess a version bump is required to edit the content of the package in PyPI. (see Can I re-upload to pypi?)

tristanlatr commented 4 years ago

Thanks for the clarifications,

I understand better now. Would it be possible to have the PKGBUILD and .SRCINFO in a python-manuf subfolder in this repository to keep track of the changes on GitHub ? Then, if I'm understanding correctly (it's late), for next version, we'de need to update links, shasum, version number and other static info (Could even use arch-linux-pkgbuild-builder-action). Then run aurpublish python-manuf (aurpublish) from the install folder and that's it.

Please tell me if that's correct.

Also, never mind the LICENSE.txt remark, just realized it's normal the file don't get to the release file .tar.gz generated by PyPi...

codeswhite commented 4 years ago

Sounds correct to me, As i dont have much knowledge about github-actions and automated workflow in general, ill have to do some research around tracking AUR build files inside a project itself and configuring the publishing action.

Might @coolbho3k have any objections?

tristanlatr commented 4 years ago

While waiting comments from repo owner @coolbho3k ...

Do you commit to publish new AUR version every time a new manuf gets release ?

Also, please document the appropriate steps in comments of setup.py so we can continue to publish to AUR.

Thanks

codeswhite commented 4 years ago

I'm able to push to AUR after every manuf's release. It might take me few days in some cases, as im travelling around the country without my laptop (right now for example i wont be home until the end of this month).

Meanwhile I will create some form of documentation as well as give partial or total ownership over the AUR package to whom it may be relevant.

P.S it feels really great taking part in contributional conversations and having influence even when the project is relatively small.

coolbho3k commented 4 years ago

Sounds awesome, thank you. Not familiar with AUR but I'm happy with you being maintainer of the package. Is it possible to share privileges with AUR?

On Wed, Jun 24, 2020 at 3:51 AM CodesWhite notifications@github.com wrote:

I'm able to push to AUR after every manuf's release. It might take me few days in some cases, as im travelling around the country without my laptop (right now for example i wont be home until the end of this month).

Meanwhile I will create some form of documentation as well as give partial or total ownership over the AUR package to whom it may be relevant.

P.S it feels really great taking part in contributional conversations and having influence even when the project is relatively small.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/coolbho3k/manuf/pull/25#issuecomment-648747491, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKBJVWA42UIVOTPRTSBG3RYHLBXANCNFSM4N5CO4TA .

codeswhite commented 4 years ago

I would like you to be co-maintainers or even owners of the package: python-manuf For us to achieve that - either of you would have to register an account on AUR and share your username with me.

tristanlatr commented 4 years ago

Hi @codeswhite ,

I'm ok with being co-maintainer with you. I just would like some form of documentation just to be sure of the process in case someone else not familliar with AUR need to upload a new version.

Also I'm stuck for my account creation because I don't have Arch linux device nor docker and there are asking me the output of the following command : LC_ALL=C pacman -V|sed -r 's#[0-9]+#c5d#g'|md5sum|cut -c1-6 ... Can you help me with that ?

Thanks