coolbutuseless / ggsvg

Use SVG images as ggplot points
https://coolbutuseless.github.io/package/ggsvg/
Other
138 stars 5 forks source link

Not every observation is visible #9

Closed unarsezer closed 2 years ago

unarsezer commented 2 years ago

Hi, I wanted to try the ggsvg package with the following codes:

svg_url <- 'https://www.svgrepo.com/download/289000/jellyfish.svg' svg_txt <- paste(readLines(svg_url), collapse = "\n")

test_df <- data.frame( x = runif(10), y = runif(10), count = sample(3:5, 10, T), type = sample(c('a', 'b', 'c'), 10, T))

ggplot(test_df) + geom_point_svg(aes(x, y), svg = svg_txt, size = 10) + theme_bw()

Interestingly, however, not every observation appears on the plot. Only 2 or 3 different observations appear every time I run the code. example

coolbutuseless commented 2 years ago

A few questions:

Which version of ggsvg? Which version of R? Is this in Rstudio? What is your operating system?

unarsezer commented 2 years ago

Hi, I am using 0.1.12 version of ggsvg. R version is 4.1.1 Yes, this is in RStudio. And I am using Windows 10.

When I add css("path", fill = "white") into the function, I can see every observation. For example,

ggplot(test_df) + geom_point_svg(aes(x, y), svg = svg_txt, size = 10, css("path", fill = "white")) + theme_bw()

the result is what it should be.


Gönderen: mikefc @.> Gönderildi: 15 Ağustos 2022 Pazartesi 23:24 Kime: coolbutuseless/ggsvg @.> Bilgi: unarsezer @.>; Author @.> Konu: Re: [coolbutuseless/ggsvg] Not every observation is visible (Issue #9)

A few questions:

Which version of ggsvg? Which version of R? Is this in Rstudio? What is your operating system?

— Reply to this email directly, view it on GitHubhttps://github.com/coolbutuseless/ggsvg/issues/9#issuecomment-1215752241, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APV5GKHVTGDPXI6GTEP66SLVZKRPTANCNFSM56SNLMWQ. You are receiving this because you authored the thread.Message ID: @.***>

coolbutuseless commented 2 years ago

Thanks for reporting this. I can't replicate this on my macOS machine, but I have some ideas on what might be happening on windows. I will need your help!

Can you install the issue09 test branch, run your "bad" plot again, and paste the output to the console as a reply to this issue?

It would also be good to see the console output for the version of your plot that works i.e. when you set css(path...)

remotes::install_github("coolbutuseless/ggsvg", ref = "issue09")

unarsezer commented 2 years ago

Let's solve this problem together.

I installed the issue09 with remotes::install_github("coolbutuseless/ggsvg", ref = "issue09")

This is the output of "bad" plot. ss1

And this is the output of css(path...) version. ss2

coolbutuseless commented 2 years ago

Both of those plots look correct to me now.

Has this fixed your issue?

If not, could you install the latest changes to the 'issue09' branch and try again?

unarsezer commented 2 years ago

Yes, everything is alright now, thanks 🙂


Gönderen: mikefc @.> Gönderildi: 20 Ağustos 2022 Cumartesi 02:50 Kime: coolbutuseless/ggsvg @.> Bilgi: unarsezer @.>; Author @.> Konu: Re: [coolbutuseless/ggsvg] Not every observation is visible (Issue #9)

Both of those plots look correct to me now.

Has this fixed your issue?

— Reply to this email directly, view it on GitHubhttps://github.com/coolbutuseless/ggsvg/issues/9#issuecomment-1221176452, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APV5GKBT34HXLVXNMJVFPGLV2AMU3ANCNFSM56SNLMWQ. You are receiving this because you authored the thread.Message ID: @.***>