search

coolcrowd / object-service

Central API service.
Apache License 2.0
0 stars 1 forks source link

Experiment recover #300

Closed kelunik closed 8 years ago

kelunik commented 8 years ago

@LeanderK We need a way to delete populations for recovery, everything else should be fine.

mention-bot commented 8 years ago

By analyzing the blame information on this pull request, we identified @LeanderK, @marcelhollerbach and @lucaskrauss to be potential reviewers

marcelhollerbach commented 8 years ago

I think a few methods can be refactored to increase readability. Nested try´s arent really nice to read. Do we need to rush here ?

kelunik commented 8 years ago

It's a bug, but no critical bug. Will just result in a incomplete experiment, which is actually fine for DRAFT state.

kelunik commented 8 years ago

Still misses platform recovery by @LeanderK.

LeanderK commented 8 years ago

what do you need?

kelunik commented 8 years ago

We need to restore platforms from before the change. Currently we just add platforms in storePopulations. But in case something failed, I don't think we want it to appear in the database at all.

LeanderK commented 8 years ago

well this is more complicated then one would think. I'll look into it when i have time

kelunik commented 8 years ago

Yes, that's why it's not done yet. We could make it the last thing we change.

LeanderK commented 8 years ago

there are still some bugs left ;)

kelunik commented 8 years ago

Hm?

LeanderK commented 8 years ago

the multiple-calibrations bug, simon mentioned that he received an invalid reservation error at the demo and when submitting only one rating was not possible. I'll create some tickets

LeanderK commented 8 years ago

i may try to do this tomorrow

LeanderK commented 8 years ago

obviously this feature was not fully realised, but the progress must not be thrown away. I would create a issue with a short description and a reference to this pull request, so that future work can start here.