search

cooler-king / quantity

A package to make it easy to work with physical quantities.
MIT License
19 stars 4 forks source link

v3.0.2 changes missing #42

Closed nebkat closed 3 weeks ago

nebkat commented 3 weeks ago

It appears that the changes from 3.0.2 have not yet been pushed?

cooler-king commented 3 weeks ago

Thanks. Updated.

nebkat commented 3 weeks ago

Thank you for the quick response.

I have also identified a bunch of issues with the unit construction functions e.g:

https://github.com/cooler-king/quantity/blob/07ce89dc48013cadca30b6292c256f401b66fe28/lib/src/si/types/mass_density.dart#L54-L62

Which should be mu.valueSI / vu.valueSI. I am currently working through these and can provide a PR.

Would there be an appetite for further PRs with non-essential fixes and improvements or is the package somewhat dormant?

cooler-king commented 3 weeks ago

I'm not actively adding new features but I'll fix any problems anyone finds.

nebkat commented 3 weeks ago

No worries - I'll submit a fix for the above first, and I can offer up some PRs after but will probably continue with more aggressive changes in a fork. Thank you for the excellent library!

cooler-king commented 1 day ago

Working on these unit fixes now.