coolharsh55 / kwest

Automatically exported from code.google.com/p/kwest
0 stars 0 forks source link

TagLib Errors #9

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Following errors are reported while extraction of metadata from certain files.

TagLib: MPEG::Properties::read() -- Could not find a valid last MPEG frame in 
the stream.

TagLib: ID3v2.4 no longer supports the frame type RVAD.  It will be discarded 
from the tag.

TagLib: ID3v2.4 no longer supports the frame type TDAT.  It will be discarded 
from the tag.

TagLib: MPEG::Header::parse() -- Invalid sample rate.

Debug code to avoid printing errors on Terminal.

Original issue reported on code.google.com by euphoric...@gmail.com on 14 Jan 2013 at 6:37

GoogleCodeExporter commented 9 years ago
I am not sure that suppressing errors is a good thing. The user should know 
that the file, though usable, is not in perfect state. That seems to be quite 
common. What if the file is NOT a valid file at all? The user should know.

Original comment by pha...@gmail.com on 20 Jan 2013 at 4:10

GoogleCodeExporter commented 9 years ago
Of course, what would be REALLY nice is if we could generate a user friendly 
message
instead of the mildly cryptic messages that seem to be generated. 

Discard all  unimportant messages, and convert the important ones into more 
user friendly messages.

Original comment by pha...@gmail.com on 20 Jan 2013 at 4:17

GoogleCodeExporter commented 9 years ago
Yes, since the importing files part is not under fuse, we can print our own 
message. The errors mentioned above are reported by Taglib and makes no sense 
to user, so we shall discard those.

Original comment by euphoric...@gmail.com on 20 Jan 2013 at 8:32

GoogleCodeExporter commented 9 years ago
if the file is NOT a valid (music) file, it won't be tagged under music...
I guess, we should print a file and all it's tags
Also, error messages should be given only for error related to kwest - eg. 
artist missing and so on... or file could not be opened

Original comment by coolharsh55 on 20 Jan 2013 at 6:59