cooljeanius / The_Earths_Gut

The Earth's Gut (TEG) is a Wesnoth add-on campaign; originally by @anonymissimus
https://forums.wesnoth.org/viewtopic.php?f=8&t=26800
GNU General Public License v2.0
6 stars 6 forks source link

Aiglathing loses his hero ellipse upon advancement #23

Closed cooljeanius closed 2 years ago

cooljeanius commented 2 years ago

From S03, "Breakthrough", on my current 1.16 playthrough:

Screen Shot 2022-06-02 at 22 18 59
cooljeanius commented 2 years ago

This is pretty minor

cooljeanius commented 2 years ago

Aiglathing uses the {IS_HERO} macro for his hero ellipse, which apparently is the cause for this: https://github.com/cooljeanius/The_Earths_Gut/blob/5091dfe06de9c088694bec74bd967155b50a0cda/scenarios/01t_The_old_home.cfg#L129-L158

cooljeanius commented 2 years ago

The {IS_HERO} ellipse is also used in this campaign for: Dulatus, Delfador, Kalenz, Parandra, and Elara.

cooljeanius commented 2 years ago

So yeah it turned out that this is a bug on Wesnoth's end that should get fixed in the next releases; I'm leaving this open for the releases to land, and/or for me to decide if I want to add any compatibility code for players with old saves.

cooljeanius commented 2 years ago

So yeah it turned out that this is a bug on Wesnoth's end that should get fixed in the next releases; I'm leaving this open for the releases to land, and/or for me to decide if I want to add any compatibility code for players with old saves.

ok so yeah I can confirm that this is fixed as of Wesnoth 1.16.6; I'm not going to bother with any compatibility code