search

cooljeanius / The_Earths_Gut

A Wesnoth add-on campaign; originally by Anonymissimus
https://forums.wesnoth.org/viewtopic.php?f=8&t=26800
GNU General Public License v2.0
6 stars 6 forks source link

Delfador's "Teaching" ability should affect allied units #31

Open cooljeanius opened 2 years ago

cooljeanius commented 2 years ago

@knyghtmare often proposes this idea for HttT, but Delfador is present here, too, so this could serve as a proof-of-concept for it

cooljeanius commented 2 years ago

ok so after looking how UtBS does "Teaching" it looks like this will be a little bit more complicated than I thought; there's one macro for the ability, and then another for the events, so it's more than just a simple matter of plopping them in the unit definition... (also Delfador is created in multiple places, so...)

cooljeanius commented 1 year ago

OK so that was actually simpler than I thought; fixed via 38e9208.

knyghtmare commented 1 year ago

This would have been better if HttT also gave it to Delfador

cooljeanius commented 1 year ago

This would have been better if HttT also gave it to Delfador

well they still can! Think of this as like a "proof of concept" to help convince mainline to make the change, too.

cooljeanius commented 1 year ago

...actually I'm going to reopen this, because in S15 Delfador is the only unit on his side, so the ability is useless to him. I'm going to want to modify the ability to allow it to apply to allied units (will require teaching myself more of the Lua API)