S18, "Illuvèn": 3 behaviors of concern

[k-konami]

3 behaviors

• [ ] "$unit.race" content is displayed in English, but probably cannot be translated in its current state.

  • Fiannon's line: https://github.com/cooljeanius/dawn_of_thunder/blob/ba69c92bfc2af73e0846440d75091bcf1f85e384/scenarios/18_Illuv%C3%A8n.cfg#L489

• [x] It should be clearly stated that Naia will "Close the Portal".

  • objectives: https://github.com/cooljeanius/dawn_of_thunder/blob/a85a8c1e16c77125bfcfb7a00856f50fb4b0808c/scenarios/18_Illuv%C3%A8n.cfg#L586

• [x] Even if the portal is not closed, it will end when the enemies are defeated.

[cooljeanius]

ok in 6c0bbae I fixed the 2nd one, I'm not quite sure how to fix the 1st one, and the 3rd one I'd already noted, but I'm kind of hesitant to fix it, as I'm not quite sure what new problems might arise as a result of fixing it...

[k-konami]

I don't know how to fix both 1st and 3rd.... sorry.

[cooljeanius]

well for the 3rd one I'd just switch victory_when_enemies_defeated= from yes to no, but it's the follow-up effects of doing so that I'm not sure about; I don't know if doing so might result in the scenario becoming unwinnable...

[k-konami]

In several places,

                [variable]
                    name=victory_conditions
                    equals=3
                [/variable]

are described. I think this counter will not reach 3 until the portal is closed, so it will probably be ok. (But I'm not sure :) )

p.s. I just tried that( to change "yes" to "no" ), but it didn't work... I checked with debugger's "inspect" and it still has victory_conditions = 2. I wonder why? I guess I need to play it from the beginning of the scenario...

[cooljeanius]

ok I think I've got the 3rd item fixed with aed01a5 and ba69c92

[cooljeanius]

edited the original post to make it a checklist, to show progress