coollabsio / coolify

An open-source & self-hostable Heroku / Netlify / Vercel alternative.
https://coolify.io
Apache License 2.0
34.43k stars 1.87k forks source link

[Bug]: App has too many 'webhook_commit' instances #1006

Closed henk23 closed 1 year ago

henk23 commented 1 year ago

Is there an existing issue for this?

Example public repository

coolify

Description

I don't know how it happend, but for every commit my app is built 5 times. First build takes around 50 seconds. Every consecutive build has a container image "found locally" and only takes 5s.

Expectation: There is only one build on a commit.

screenshot

Steps To Reproduce

Don't know how it happened. But I cannot get rid of the extra builds.

Version

3.12.29

henk23 commented 1 year ago

Found the issue:

gitlab-webhooks

Too many of the same GitLab webhooks are created. I think there was a problem in my browser connecting to GitLab at the time. Just deleted all but one of the webhooks.

Maybe add a check in coolify to first check for existing webhook and then skip adding another one?

edgardoll4 commented 1 year ago

I have a problem with the implementation of a gitlab repository in coolify, the project is up and everything, but before when I made a commit to the branch that is deployed it is in coolify it autodeployed automatically, but now I don't want to do it.

I tried the URL and the result that it gives me, I tried it with two different gitlab accounts and it gives me the same error

example: https://panel.dominio.xyz./webhooks/gitlab

{ "status": 500, "message": "Cannot read properties of null (reading 'appId')" }

In gitlab I search the repository and go to the webhooks and I get the following:

image

When I do the test from gitlab I get the following error

image

andrasbacsai commented 1 year ago

I'm closing this issue, because tracking features will be moved to GitHub discussions. Github issues will be only for bugs.

Version 4 is in full focus. v3 related issues will be closed, if it is not a critical bug.

Thanks for your understanding.