[Impovement]: Add more notifcation options

coollabsio / coolify

An open-source & self-hostable Heroku / Netlify / Vercel alternative.

https://coolify.io

Apache License 2.0

30.62k stars 1.55k forks source link

[Impovement]: Add more notifcation options #2526

Closed peaklabs-dev closed 1 week ago

peaklabs-dev commented 2 months ago

Description

The notification is great it would be amazing if we could have some more options

Minimal Reproduction (if possible, example repository)

More options:

[ ] Add slack notifications
[ ] Add error notification -> when deployments fail and not always
[ ] Send a notification always when an admin logs into coolify
[ ] Update notifications for coolify panel updates
[ ] Update notifications for docker images: https://github.com/coollabsio/coolify/issues/2500

Exception or Error

No response

Version

yohannlog commented 2 months ago

Hi! I did a PR for the first request: #2601

peaklabs-dev commented 2 months ago

Hi! I did a PR for the first request: #2594

Thank you so much.

RayBB commented 2 months ago

@yohannlog @ayntk-ai how would you feel about integrating with apprise so that just about any platform could be used to send notifications? https://github.com/caronc/apprise changedetection.io uses this and it works quite nicely!

peaklabs-dev commented 2 months ago

@yohannlog @ayntk-ai how would you feel about integrating with apprise so that just about any platform could be used to send notifications? https://github.com/caronc/apprise changedetection.io uses this and it works quite nicely!

Looks nice, but I and also the maintainer I believe do not like external dependecies that are not absolutely necessary. So native integrations would be better. But overall I would have nothing against this, maybe in addition to native integrations for some more neach providers.

peaklabs-dev commented 2 months ago

I think native notifications should be (as they are the most common):

[x] email
[ ] Amazon SES for email
[ ] slack -> pull request open
[x] discord
[x] telegram
[ ] whatsapp
[ ] signal
[ ] matrix
[ ] teams
[ ] push notifications for phone and pcs -> maybe browser based push notifications

-> and a webhook option ao we can use external services like zapier:

[ ] webhook

yohannlog commented 2 months ago

@yohannlog @ayntk-ai how would you feel about integrating with apprise so that just about any platform could be used to send notifications? https://github.com/caronc/apprise changedetection.io uses this and it works quite nicely!

Even if I like this solution, the problem is that you have to write the pages and code to support all the options for this package, so I don't know if it would be a time saver.

Besides, I don't know if this would be of much interest to the owner of this repo. Mainly for safety reasons.<

Edit: I will re-create the PR because I push it on the main (in my repo) and not a new branch

RayBB commented 2 months ago

For context, this is how change detection uses apprise. As far as I know, it is only used on this page and the page for manual overrides.

yohannlog commented 2 months ago

For context, this is how change detection uses apprise. As far as I know, it is only used on this page and the page for manual overrides.

I will take a look. But the notification body is a great idea.

knurzl commented 2 months ago

It would be also great to just send notifications when anything doesnt works and not always.