ity-alex
commented
4 months ago I found these two possibly relevant code sections:
-
Deleting a PR container by webhook when the PR closes (here something seems to be missing): https://github.com/coollabsio/coolify/blob/de7380fb0ca92c497ca547b2f67952f499a2521d/app/Http/Controllers/Webhook/Github.php#L422-L428
-
Cancelling a running deploy, which seems to remove the container correctly: https://github.com/coollabsio/coolify/blob/de7380fb0ca92c497ca547b2f67952f499a2521d/app/Livewire/Project/Application/DeploymentNavbar.php#L58
Maybe the deletion by webhook only removes the final container, while the cancelling of the deploy removes the currently building container. Possible solution would be to check for currently active deploys in the webhook handler?
TorstenDittmann
Description
When connecting a resource via Github App and opening a PR, a preview deployment gets queued. If the PR is merged right after it is created (few seconds) the deployment stalls (I assume because there is nothing to pull from?), blocks the queue and the new docker container will not get cleaned up.
We are using the hosted interface at app.coolify.com, love this project so far! This is only a minor issue, not urgent for us at all!
All the best!
Minimal Reproduction (if possible, example repository)
Connect source as Github App, open Pull Request, wait only 2-3 seconds, close/merge the PR.
Exception or Error
No response
Version
v4.0.0-beta.297