[Bug]: Bitbucket Previews are not updated on push

coollabsio / coolify

An open-source & self-hostable Heroku / Netlify / Vercel alternative.

https://coolify.io

Apache License 2.0

31.8k stars 1.64k forks source link

[Bug]: Bitbucket Previews are not updated on push #2793

Open lorenzomigliorero opened 2 months ago

lorenzomigliorero commented 2 months ago

Description

Pushing to a PR branch doesn't update the Preview deployment. This is the response from /webhooks/source/bitbucket/events/manual:

{"status":"failed","message":"Nothing to do. No applications found with deploy key set, branch is '***' and Git Repository name has ***"}

Minimal Reproduction

Create an application with BitBucket repository as its source
Set up the BitBucket webhook && enable preview deployments
Create PR in the repo
Push to the PR branch
Preview deployment isn't updated

Version

v4.0.0-beta.307

Xiloe commented 2 months ago

Yes, coolify doesn't support the pullrequest:updated request from bitbucket.

Same for Gitea, Gitlab, Github by the way, it's not a PR Preview feature (yet). You can however redeploy the PR manually on the UI and it should work just fine since it pulls from the PR's head, I'll see if I can do a PR in a few days, if it's not already done.

lorenzomigliorero commented 2 months ago

@Xiloe Thanks for the answer! Actually, a manual PR redeploy always fetches the HEAD instead of the PR branch (I've only tested Bitbucket private repos with deployment keys). I opened another issue here https://github.com/coollabsio/coolify/issues/2792.

Xiloe commented 2 months ago

I'll look at this later tomorrow, seems like it's the same issue that was going on with gitea that I fixed and got merged in version 308