[Bug]: Source git branch doesn't update

coollabsio / coolify

An open-source & self-hostable Heroku / Netlify / Vercel alternative.

https://coolify.io

Apache License 2.0

31.18k stars 1.59k forks source link

[Bug]: Source git branch doesn't update #2895

Open lorenzomigliorero opened 1 month ago

lorenzomigliorero commented 1 month ago

Description

The source git branch doesn't update on a public repository / docker-compose. I didn't test other build-packs/resource types.

Minimal Reproduction

https://www.loom.com/share/46359b1ba1864ac3a8cad54c64e04de0

Add a new resource
Select public repository
Use https://github.com/verdaccio/verdaccio as repo URL
Select docker-compose as Build Pack
Paste /docker-examples/v4/docker-local-storage-volume as base directory
Go to source and update git branch to master
Go to general and click Reload Compose File

Exception or Error

No response

Version

317

Cloud?

[ ] Yes
[X] No

SapphSky commented 1 month ago

I've encountered this issue as well just now on the cloud version

SapphSky commented 1 month ago

Hey, following up after doing a bit of trial and error. I got my scenario to work by pasting the branch tree URL as the repo URL when creating the resource. In your case, it would be https://github.com/verdaccio/verdaccio/tree/master. The tooltip on the Repository URL explains how the branch is selected this way. Hope this helps

replete commented 1 month ago

Since 4 beta .317 added Preserve Repository During Deploymentit works once and then never seems to update the git repo, so the webhook rebuilds are running an old version of the app. Presumably it is not clearing the mounted volume. Giving up volumes for a bit until this is work as expected