search

coollabsio / coolify

An open-source & self-hostable Heroku / Netlify / Vercel alternative.
https://coolify.io
Apache License 2.0
31.55k stars 1.61k forks source link

[Bug]: Git-based Docker Compose deployment is Broken #3277

Closed brandnewx closed 1 week ago

brandnewx commented 2 weeks ago

Description

So today Docker Compose applications from Git are no longer deployable because Coolify or Coolify Helper docker image has this new bug where it generated a malformed .env file during building.

See Deployment logs:

[COMMAND] docker exec xxxxx bash -c 'SOURCE_COMMIT=xxxxx COOLIFY_BRANCH=main docker compose --env-file /artifacts/xxxxx/.env --project-name xxxxx --project-directory /artifacts/xxxxx-f /artifacts/xxxx/docker-compose.yml build --pull'
[OUTPUT]
failed to read /artifacts/xxxxxx/.env: line 4: key cannot contain a space

[2024-Aug-31 06:44:00.474211] Oops something is not okay, are you okay? 😢

[2024-Aug-31 06:44:00.657908] failed to read /artifacts/xxxxx/.env: line 4: key cannot contain a space

Minimal Reproduction (if possible, example repository)

Create new application > Git Repository > Choose Docker Compose. Deploy and you'll see the bug.

Exception or Error

No response

Version

v4.0.0-beta.324

Cloud?

vanWittlaer commented 2 weeks ago

Same here

nnti3n commented 1 week ago

Same here, cant deploy

[2024-Sep-03 09:56:06.921547] Preparing container with helper image: ghcr.io/coollabsio/coolify-helper:latest.
[2024-Sep-03 09:56:09.364622] ----------------------------------------
[2024-Sep-03 09:56:09.369067] Importing *** (commit sha HEAD) to /artifacts/hcc80c840gg08084c4ss4w8o.
[2024-Sep-03 09:56:14.882095] Pulling & building required images.
[2024-Sep-03 09:56:15.311128] Oops something is not okay, are you okay? 😢

[2024-Sep-03 09:56:15.313833] failed to read /artifacts/hcc80c840gg08084c4ss4w8o/.env: line 4: key cannot contain a space
aschelch commented 1 week ago

Same here !

Edit: In the meantime, try removing space in your project name (and "/" in your ressource name). On my side, it unblock the situation ;)

adaichendt-tv1 commented 1 week ago

Downgrade to beta 323 for now. You don't need to comment that it affects you too, simply hit the thumbs up button below the initial report.

Pokymon commented 1 week ago

Same here. Just two hours ago, I got this exact same bug.

andrasbacsai commented 1 week ago

This will be fixed in the upcoming version in #3306 , but I would like you to test it as well. I could not reproduce it after the fix.

Edit: It is released. Can you please test?

pipegalera commented 1 week ago

@andrasbacsai I deployed 1 hour ago after updating and no problem on simple a static site based on a Github repo.

Docker worked without fails, thanks champ!