coollabsio / coolify

An open-source & self-hostable Heroku / Netlify / Vercel alternative.
https://coolify.io
Apache License 2.0
34.01k stars 1.84k forks source link

[Bug]: Faulty parsing of Docker volumes in yml compose #3419

Closed busybox11 closed 1 month ago

busybox11 commented 1 month ago

Description

Using the following volume definition:

volumes:
      - ./otel-collector-config.yaml:/etc/otel-collector-config.yaml
      - ./otel-collector-opamp-config.yaml:/etc/manager-config.yaml
      - /var/lib/docker/containers:/var/lib/docker/containers:ro
      - /:/hostfs:ro

Coolify is unable to parse the last entry (- /:/hostfs:ro), resulting in an empty source path inside the Storages view and the following deploy error:

invalid spec: :/hostfs: empty section between colons

image

When manually deploying the same compose, I don't have any errors.

Minimal Reproduction (if possible, example repository)

Try to deploy SigNoz (https://github.com/SigNoz/signoz.git) without any modifications using /deploy/docker/clickhouse-setup/docker-compose.yaml.

Exception or Error

See above

Version

v4.0.0-beta.335

Cloud?

busybox11 commented 1 month ago

Tried forking SigNoz to wrap those lines with quotes, just in case it was only a parsing error, but this didn't help. (repo is https://github.com/busybox11/SigNoz.git)

The source path is still empty.

image

For the record -- I forgot to mention that the app deploys well when Raw Compose Deployment is turned on.


EDIT: I can confirm the repo deploys without any issue when using a symlink to /, in my case using /user/ubuntu/signoz/root (see coolify-fix branch on the fork). This leads me to believe the issue comes from the use of only / as a source directory - which for now is interpreted as an invalid file.

andrasbacsai commented 1 month ago

This will be fixed in the upcoming version.