chore: add registry auth to docker image apps

OSINTRoach commented 1 week ago

Changes

Added docker login and logout for docker images application with registry url, username and token/password input on frontend

OSINTRoach commented 1 week ago

I would like some input on this, I have some questions ex:

Password/token is shown on debug logs, should it be like that
Should i encrypt token ?
I can't fully test because I have some problems with my local deployment on my mac so not fully tested so I need help with that

peaklabs-dev commented 1 week ago

Password/token is shown on debug logs, should it be like that

No it should only show like on GitHub actions for example -> Like REGISTRY_SECRET only show the env or so not the value

Should i encrypt token

Yes please - all sensitive data needs to be encrypted (passwords tokens etc), very simple to implement thanks to Laravel

I can't fully test because I have some problems with my local deployment on my mac so not fully tested so I need help with that

What issues are you facing, maybe DM me or open discussion on Discord

peaklabs-dev commented 6 days ago

Thanks for taking the time to improve the PR. Overall the PR is coming along nicely. If you have time, I would like to see the following adjustments:

Add a new database table for registrations (they should be stored in a separate table)
Move the UI for adding registries to a new section called Images in the sidebar (the sidebar on the left) and once clicked there will be a page with two horizontal tabs (on top - like on the new server view) the first tab is called Images (nothing there yet) and the second tab is called Registries. And there we should have an add button and then a form for different registries for the most popular registries like docker hub, grc (google), ghrc.io (GitHub container registry), quay and so on.
On deployment, dockerfile, docker images, nixpacks etc everywhere add the checkbox you have already added (so each deployment type can use a custom/ private registry) and then instead of giving the fields once the checkbox is enabled add a dropdown where the user can select from one of the registries added in the registries tab.

If you need help with anything just let me know.

peaklabs-dev commented 3 days ago

The first Images tab will be for displaying all the docker images on the user's system (all servers or maybe per server would be better) and also offer to delete them individually or remove all the unused images with the click of a button, also it should show the total storage used by images somewhere on top. And when you click on an image you can see details like the architecture it supports, the size of the image and so on.

peaklabs-dev commented 2 days ago

I also found an Icon you can use, same one as in docker desktop: https://tablericons.com/icon/cube-3d-sphere.