search

coollabsio / coolify

An open-source & self-hostable Heroku / Netlify / Vercel alternative.
https://coolify.io
Apache License 2.0
34.73k stars 1.9k forks source link

[Bug]: Install.sh should use JQ and fallback to "latest" doesnt seem to work? #4344

Closed LaurenceJJones closed 5 days ago

LaurenceJJones commented 5 days ago

https://github.com/coollabsio/coolify/blob/092bd916ff2a143d9f657bae1764598313164c8a/scripts/install.sh#L117-L119

within the installation script we attempt to parse the versions from the CDN using a mixture of commands, however, a dependency is jq package which can easily handle this parsing alot simpler and could ensure we get a proper json response.

This may mean we need to move the the logging of the versions after the dependency installation. Also a fallback of "latest" doesnt seem correct as we dont tag any image with "latest" anymore from GHCR or Docker

LaurenceJJones commented 5 days ago

Edit: latest does seem to work, I dont know what happened to me, may be the parsing didnt go as expected.

I will close the issue as not planned and throw it in the discussions